Add modules in PYTHONPATH to watched modules #845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tconkling
approved these changes
Dec 17, 2019
Contributor
tconkling
left a comment
There was a problem hiding this comment.
👍 I left some nitpicky performance-related comments that you should feel free to disagree with :)
| os.path.abspath(path) for path in pythonpath.split(os.pathsep) | ||
| ] | ||
| return any( | ||
| file_is_in_folder_glob(os.path.normpath(filepath), path) |
Contributor
There was a problem hiding this comment.
Why does this use file_is_in_folder_glob? Does filepath ever have glob syntax?
Collaborator
Author
There was a problem hiding this comment.
Good point, I basically just reusing...
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Jan 7, 2020
* develop: @st.cache: do not support arbitrary keyword args. (streamlit#915) Change copyright from 2019 to 2020 (streamlit#924) Update getting_started.md (streamlit#919) Make all doc URLs point to docs.streamlit.io (new domain) (streamlit#918) Update main_concepts.md (streamlit#917) Fix doc selectbox (streamlit#908) Bump handlebars from 4.2.0 to 4.5.3 in /frontend (streamlit#901) Fix how st.write docs render in Sphinx (streamlit#891) Fix streamlit#875: frontend error saying "Bad message format - Tried to use SessionInfo before it was initialized" (streamlit#889) Auto-reload page if Streamlit server version ≠ frontend version (streamlit#874) File uploader unit tests (streamlit#880) Release 0.52.0 (streamlit#849) Fixing min max behavior (streamlit#876) FullScreenWrapper HOC (streamlit#858) Add modules in PYTHONPATH to watched modules (streamlit#845) Update the Cached Object Mutated warning (streamlit#839) test:coverage script (streamlit#847) add new tests for add_rows method with set_index in dataframes (streamlit#851) add_rows support no index column (streamlit#795)
This was referenced Feb 28, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently limit the modules we watch to modules contained in the current directory. This PR extends the watched modules to modules contained in the
PYTHONPATHas well. For consistency, we also enable hashing for the same modules in thePYTHONPATH.Issue: #805