Add more correct out of bounds checks for min_value and max_value for st.number_input and st.slider, related to st.session_state #9964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hey @jiangpli Sorry for the delay! This must've gotten lost in the holidays. And thank you for helping us resolve the bug. Overall the code looks great. I'm trying to get the tests to run but I think we might need to rebase off develop. Would you mind doing that? Assuming the tests all pass, happy to merge in this change. |
kmcgrady
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
I added more checks to fix the issue describe in #9342 so that Streamlit now throws an StreamlitValueAboveMaxError/StreamlitValueBelowMinError if a value is set out of bounds for st.number_input or st.slider via st.session_state. Let me know if I'm on the right track, or what other requirements I need to change for my code. Thank you!
GitHub Issue Link (if applicable)
#9342
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.