Add Tax ID Element Types #604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/types/index.ts
Outdated
Comment on lines
849
to
854
| onLoadError?: (event: {elementType: 'address'; error: StripeError}) => any; | ||
|
|
||
| /** | ||
| * Triggered when the [loader](https://stripe.com/docs/js/elements_object/create#stripe_elements-options-loader) UI is mounted to the DOM and ready to be displayed. | ||
| */ | ||
| onLoaderStart?: (event: {elementType: 'address'}) => any; |
There was a problem hiding this comment.
Should these elementTypes be taxId?
src/types/index.ts
Outdated
Comment on lines
834
to
839
| onChange?: (event: stripeJs.StripeAddressElementChangeEvent) => any; | ||
|
|
||
| /** | ||
| * Triggered when the Element is fully rendered and can accept imperative `element.focus()` calls. | ||
| */ | ||
| onReady?: (element: stripeJs.StripeAddressElement) => any; |
There was a problem hiding this comment.
Same with these event/element types
jackieosborn-stripe
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & motivation
API review
Copy this template or link to an API review issue.
API Review
Testing & documentation