Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

wobsoriano
Copy link
Contributor

@wobsoriano wobsoriano commented Aug 19, 2025

Summary & motivation

Small PR that updates elements links.

OT: Would you be interested in updating the testing framework from jest to vitest? I can open a PR if interested 🫡

API review

Copy this template or link to an API review issue.

Testing & documentation

Copy link

cla-assistant bot commented Aug 19, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Aug 19, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
Copy link

cla-assistant bot commented Aug 19, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@dodgez-stripe dodgez-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

Regarding switching to vitest, I'll bring this to the team to see what they think. My first thought is we'll likely hold off on a change like that to match other repos we have, but could revisit down the line

@dodgez-stripe dodgez-stripe merged commit d2a2cdf into stripe:master Aug 25, 2025
2 checks passed
@wobsoriano
Copy link
Contributor Author

Awesome, thanks @dodgez-stripe! No rush about the test stuff 😄

Also, love how this React wrapper is implemented, so I wrote a 1:1 equivalent for Vue https://github.com/wobsoriano/vue-stripe

thanks again

alanyan-stripe pushed a commit to alanyan-stripe/react-stripe-js that referenced this pull request Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants