feat: enabled gzip compression for OpenSearch logs #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables gzip compression for OpenSearch logs in FireLens configurations to improve performance of bulk requests as recommended by AWS.
- Adds
Compress = "gzip"to the FireLens log options in both the Envoy and application container definitions - Aligns with AWS best practices for log ingestion performance
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| envoy.tf | Added Compress = "gzip" to FireLens options |
| container_definition.tf | Added Compress = "gzip" to FireLens options |
Comments suppressed due to low confidence (1)
container_definition.tf:20
- Consider adding a Terraform plan assertion or a Terratest case to verify that the
Compressoption is set togzip, ensuring this configuration is applied in CI.
Compress = "gzip"
|
|
||
| logConfiguration = var.firelens.enabled && var.firelens.opensearch_host != "" ? { | ||
| logDriver = "awsfirelens", | ||
| options = { |
There was a problem hiding this comment.
[nitpick] The Compress = "gzip" option is duplicated in both Terraform files; consider extracting shared FireLens options into a local variable or module to avoid repetition.
Copilot uses AI. Check for mistakes.
|
we need at least FluentBit 2.x for this setting, https://github.com/aws/aws-for-fluent-bit/releases/tag/v2.32.5.20250626 is currently based on 1.9.10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds compression settings to the logging configuration for OpenSearch in two Terraform files:
container_definition.tfandenvoy.tf.AWS recommends to enable ´gzip´ compression for bulk requests for performance reasons, so we use it by default.
Logging Configuration Updates:
container_definition.tf: Added theCompressoption set to"gzip"in the logging configuration for application logs.envoy.tf: Added theCompressoption set to"gzip"in the logging configuration for Envoy logs.