Update persisted-model.js #1910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@superkhau Please review and land if it looks OK. |
lib/persisted-model.js
Outdated
Contributor
|
Just missing tabs in front of the start and end of comment block. Otherwise, LGTM. |
lib/persisted-model.js
Outdated
Contributor
There was a problem hiding this comment.
data provided in the second argument?
Contributor
Author
|
Fixed, ty. |
Contributor
Author
|
OK, fixed the notional |
lib/persisted-model.js
Outdated
- Correct doc for findOrCreate. - Fix indentation - Remove quotes in example `where` - Fix typo - Fix spacing in notional where clause
05f3476 to
1af0361
Compare
Contributor
Author
|
Thanks @superkhau !!! |
crandmck
pushed a commit
that referenced
this pull request
Jan 9, 2016
bajtos
added a commit
that referenced
this pull request
Feb 19, 2016
* Remove sl-blip from dependency (Candy) * Fix race condition in replication tests (Miroslav Bajtoš) * test: remove errant console.log from test (Ryan Graham) * Promisify Model Change (Jue Hou) * Fix race condition in error handler test (Miroslav Bajtoš) * Travis: drop iojs, add v4.x and v5.x (Miroslav Bajtoš) * Correct JSDoc findOrCreate() callback in PersistedModel (Miroslav Bajtoš) * Hide verificationToken (Miroslav Bajtoš) * test: use ephemeral port for e2e server (Ryan Graham) * test: fail on error instead of crash (Ryan Graham) * ensure app is booted before integration tests (Ryan Graham) * Checkpoint speedup (Amir Jafarian) * Pull in API doc fix from PR into master #1910 (crandmck)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct doc for findOrCreate per loopbackio/loopback-datasource-juggler#766