Use GitHub issue templates #2810

superkhau · 2016-10-01T00:31:29Z

First run of using issue templates, please note we will should update this over time with the feedback we receive from community.

Connect to #2442

@bajtos PTAL

Amir-61 · 2016-10-02T19:38:33Z

ISSUE_TEMPLATE.md

@@ -0,0 +1,31 @@
+**DO NOT ask questions using GitHub issues (we reserve GitHub issues for bug or feature requests only)**


for bugs or feature requests only

superkhau · 2016-10-03T21:41:49Z

ISSUE_TEMPLATE.md

@@ -0,0 +1,31 @@
+**DO NOT ask questions using GitHub issues (only bug or feature requests please see http://loopback.io/doc/en/contrib/Reporting-issues.html#asking-questions)**
+**Please ask questions at https://groups.google.com/forum/#!forum/loopbackjs or https://gitter.im/strongloop/loopback**
+**Immediate support is available through our subscription plans, see https://strongloop.com/node-js/subscription-plans**


@bajtos I'm thinking we should move this into CONTRIBUTOR.md so we don't clutter up the template (that and it shows up as a yellow bar in in the GH UI. I'm thinking of the user flow so they don't to delete this warning every time an issue is created (and we don't have to see it with every new issue submitted).

Let's use markdown comments for this. That way users filling a new issue will see the message, but the rendered issue won't show it.

bajtos · 2016-10-04T12:44:39Z

ISSUE_TEMPLATE.md

@@ -0,0 +1,31 @@
+**DO NOT ask questions using GitHub issues (only bug or feature requests please see http://loopback.io/doc/en/contrib/Reporting-issues.html#asking-questions)**
+**Please ask questions at https://groups.google.com/forum/#!forum/loopbackjs or https://gitter.im/strongloop/loopback**
+**Immediate support is available through our subscription plans, see https://strongloop.com/node-js/subscription-plans**


Let's use markdown comments for this. That way users filling a new issue will see the message, but the rendered issue won't show it.

bajtos · 2016-10-04T12:46:07Z

ISSUE_TEMPLATE.md

+
+
+
+### Link to sample repo to reproduce issue (if bug)


Let's move this more to the top, before "expected" result.

In my experience, a good bug report has the following form:

steps to reproduce

actual result

expected result

additional information like Node/LoopBack versions, etc.

bajtos

Please move the file to .github directory, so that we don't clutter project root too much.

See e.g. https://github.com/nodejs/node/tree/master/.github

superkhau · 2016-10-06T04:58:34Z

.github/ISSUE_TEMPLATE.md

+- [ ] Bug
+- [ ] Feature request
+
+### Description of feature (or steps to reproduce if bug)


@bajtos Added steps to reproduce in this step and left description to cover the case where it is a feature (and therefore has no STR).

superkhau · 2016-10-06T04:58:56Z

.github/ISSUE_TEMPLATE.md

+
+
+
+### Link to sample repo to reproduce issue (if bug)


@bajtos Also moved this up above expected results as requested.

superkhau · 2016-10-06T04:59:29Z

.github/ISSUE_TEMPLATE.md

+
+
+
+### Additional information (Node.js version, LoopBack version, etc)


@bajtos Grouped addition information together as requested.

superkhau · 2016-10-06T05:00:06Z

@bajtos PTAL again

superkhau · 2016-10-06T06:13:33Z

@rashmihunt soap connector is failing

bajtos · 2016-10-06T08:30:06Z

@rashmihunt soap connector is failing

FWIW, we have a story (loopbackio/loopback-connector-soap#36) planned for this sprint to make the tests port-independent, although I don't know if that will fix the CI failure observed here.

bajtos

LGTM. Are we going to add pull request template too?

superkhau · 2016-10-06T16:34:43Z

Are we going to add pull request template too?

Yes, in another PR. ;)

superkhau · 2016-10-12T05:07:31Z

PR for PR template integration at #2843

Backport of #2810

* Reword ticking checkbox note in issue template (#2855) (Simon Ho) * Add how to tick checkbox in issue template (#2851) (#2853) (Simon Ho) * Use GitHub issue templates (#2810) (#2852) (Simon Ho) * Allow tokens with eternal TTL (value -1) (Miroslav Bajtoš) * Update ja and nl translation files (Candy) * Fix support for remote hooks returning a Promise (Tim van der Staaij) * Validate non-email property partial update (Loay) * Update translation files - round#2 (Candy) * Update tests to use registry for model creation (gunjpan) * Call new disable remote method from model class. (Richard Pringle) * Temporarily disable Karma tests on Windows CI (Miroslav Bajtoš) * Add translation files for 2.x (Candy) * Allow resetPassword if email is verified (Loay) * Add docs for KeyValue model (Simon Ho) * Invalidate sessions after email change (Loay) * Upgrade loopback-testing to the latest ^1.4 (Miroslav Bajtoš)

* Fix use-strict issue with connectors after merge (Loay) * Fix connector naming in strict mode (ebarault) * Add "returnOnlyRoleNames" option to Role.getRoles (Eric) * Update translation files (Candy) * Fix broken document for `upsertWithWhere` (Amir Jafarian) * Fix js doc for deleteAll event (Candy) * add allowArray to relations' create remoteMethod (David Cheung) * Remove workaround for default value (Loay) * Fix remote method example (Amir Jafarian) * Remove `example/context` (Amir Jafarian) * Turn on "no-unused-expressions" rule for eslint (Miroslav Bajtoš) * Update eslint to loopback config v5 (Loay) * Fix total calculation in example (Candy) * make test individually runable (David Cheung) * Add options to bulkUpdate (Kogulan Baskaran) * Fix context within listByPrincipalType role method (codyolsen) * Add Node v7 to Travis CI platforms (Miroslav Bajtoš) * Drop support for Node v0.10 and v0.12 (Miroslav Bajtoš) * Add templateFn option to User#verify() (Adrien Kiren) * Require verification after email change (Loay) * Update doc links (Candy) * adding check of string for case insensitive emails (Dhaval Trivedi) * Update test confirmation text in PR template (#2897) (Simon Ho) * allow batch create for persisted models (David Cheung) * Fix PR template to not link all PRs to #49 (#2887) (Miroslav Bajtoš) * Need index on principalId for performance. (#2883) (Simon Ho) * Remove redundant items in PR template (#2877) (Simon Ho) * Refactor PR template based on feedback (#2865) (Simon Ho) * Add pull request template (#2843) (Simon Ho) * Update README.md (Rand McKinney) * Reword ticking checkbox note in issue template (#2854) (Simon Ho) * Add how to tick checkbox in issue template (#2851) (Simon Ho) * Fix description of updateAll response (Miroslav Bajtoš) * Allow tokens with eternal TTL (value -1) (Miroslav Bajtoš) * Use GitHub issue templates (#2810) (Simon Ho) * Update ja and nl translation files (Candy) * Remove 3.0 DEVELOPING & RELEASE-NOTES (Miroslav Bajtoš) * Fix support for remote hooks returning a Promise (Tim van der Staaij) * Validate non-email property partial update (Loay) * Update release notes (Amir Jafarian) * Update translation files - round#2 (Candy) * Add license text (Candy) * Temporarily disable Karma tests on Windows CI (Miroslav Bajtoš)

* Fix use-strict issue with connectors after merge (Loay) * Fix connector naming in strict mode (ebarault) * Add "returnOnlyRoleNames" option to Role.getRoles (Eric) * Update translation files (Candy) * Fix broken document for `upsertWithWhere` (Amir Jafarian) * Fix js doc for deleteAll event (Candy) * add allowArray to relations' create remoteMethod (David Cheung) * Remove workaround for default value (Loay) * Fix remote method example (Amir Jafarian) * Remove `example/context` (Amir Jafarian) * Turn on "no-unused-expressions" rule for eslint (Miroslav Bajtoš) * Update eslint to loopback config v5 (Loay) * Fix total calculation in example (Candy) * make test individually runable (David Cheung) * Add options to bulkUpdate (Kogulan Baskaran) * Fix context within listByPrincipalType role method (codyolsen) * Add Node v7 to Travis CI platforms (Miroslav Bajtoš) * Drop support for Node v0.10 and v0.12 (Miroslav Bajtoš) * Add templateFn option to User#verify() (Adrien Kiren) * Require verification after email change (Loay) * Update doc links (Candy) * adding check of string for case insensitive emails (Dhaval Trivedi) * Update test confirmation text in PR template (strongloop#2897) (Simon Ho) * allow batch create for persisted models (David Cheung) * Fix PR template to not link all PRs to strongloop#49 (strongloop#2887) (Miroslav Bajtoš) * Need index on principalId for performance. (strongloop#2883) (Simon Ho) * Remove redundant items in PR template (strongloop#2877) (Simon Ho) * Refactor PR template based on feedback (strongloop#2865) (Simon Ho) * Add pull request template (strongloop#2843) (Simon Ho) * Update README.md (Rand McKinney) * Reword ticking checkbox note in issue template (strongloop#2854) (Simon Ho) * Add how to tick checkbox in issue template (strongloop#2851) (Simon Ho) * Fix description of updateAll response (Miroslav Bajtoš) * Allow tokens with eternal TTL (value -1) (Miroslav Bajtoš) * Use GitHub issue templates (strongloop#2810) (Simon Ho) * Update ja and nl translation files (Candy) * Remove 3.0 DEVELOPING & RELEASE-NOTES (Miroslav Bajtoš) * Fix support for remote hooks returning a Promise (Tim van der Staaij) * Validate non-email property partial update (Loay) * Update release notes (Amir Jafarian) * Update translation files - round#2 (Candy) * Add license text (Candy) * Temporarily disable Karma tests on Windows CI (Miroslav Bajtoš)

superkhau assigned bajtos Oct 1, 2016

superkhau added the #review label Oct 1, 2016

Amir-61 reviewed Oct 2, 2016

View reviewed changes

superkhau force-pushed the add-issue-template branch from cd56da7 to a80fd17 Compare October 3, 2016 21:40

superkhau commented Oct 3, 2016

View reviewed changes

superkhau force-pushed the add-issue-template branch from a80fd17 to 06ae283 Compare October 3, 2016 21:45

bajtos suggested changes Oct 4, 2016

View reviewed changes

bajtos reviewed Oct 4, 2016

View reviewed changes

superkhau force-pushed the add-issue-template branch 2 times, most recently from 8e3ebed to 535e71a Compare October 6, 2016 04:45

Use GitHub issue templates

a02dd25

superkhau force-pushed the add-issue-template branch from 535e71a to a02dd25 Compare October 6, 2016 04:57

superkhau commented Oct 6, 2016

View reviewed changes

bajtos approved these changes Oct 6, 2016

View reviewed changes

bajtos assigned superkhau and unassigned bajtos Oct 6, 2016

superkhau merged commit ee4d79f into master Oct 6, 2016

superkhau deleted the add-issue-template branch October 6, 2016 16:35

superkhau removed the #review label Oct 6, 2016

superkhau restored the add-issue-template branch October 7, 2016 05:34

superkhau deleted the add-issue-template branch October 7, 2016 05:34

superkhau added a commit that referenced this pull request Oct 12, 2016

Use GitHub issue templates (#2810)

6f20421

Backport of #2810

superkhau mentioned this pull request Oct 12, 2016

Use GitHub issue templates (#2810) #2852

Merged

superkhau added a commit that referenced this pull request Oct 13, 2016

Use GitHub issue templates (#2810) (#2852)

f72fb69

Backport of #2810

		@@ -0,0 +1,31 @@
		DO NOT ask questions using GitHub issues (we reserve GitHub issues for bug or feature requests only)




		### Additional information (Node.js version, LoopBack version, etc)

Use GitHub issue templates #2810

Use GitHub issue templates #2810

Uh oh!

Conversation

superkhau commented Oct 1, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Amir-61 Oct 2, 2016

Choose a reason for hiding this comment

Uh oh!

superkhau Oct 3, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bajtos Oct 4, 2016

Choose a reason for hiding this comment

Uh oh!

bajtos Oct 4, 2016

Choose a reason for hiding this comment

Uh oh!

bajtos Oct 4, 2016

Choose a reason for hiding this comment

Uh oh!

bajtos left a comment

Choose a reason for hiding this comment

Uh oh!

superkhau Oct 6, 2016

Choose a reason for hiding this comment

Uh oh!

superkhau Oct 6, 2016

Choose a reason for hiding this comment

Uh oh!

superkhau Oct 6, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

superkhau commented Oct 6, 2016

Uh oh!

superkhau commented Oct 6, 2016

Uh oh!

bajtos commented Oct 6, 2016

Uh oh!

bajtos left a comment

Choose a reason for hiding this comment

Uh oh!

superkhau commented Oct 6, 2016

Uh oh!

superkhau commented Oct 12, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

superkhau commented Oct 1, 2016 •

edited

Loading

superkhau Oct 3, 2016 •

edited

Loading

superkhau Oct 6, 2016 •

edited

Loading

superkhau commented Oct 12, 2016 •

edited

Loading