Refactor PR template based on feedback (#2865) #2874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated based on feedback received during sprint demo. Backport of #2865
bajtos
added a commit
that referenced
this pull request
Oct 24, 2016
* Need index on principalId for performance. (#2883) (#2884) (Simon Ho) * Remove redundant items in PR template (#2877) (#2878) (Simon Ho) * Refactor PR template based on feedback (#2865) (#2874) (Simon Ho) * Add pull request template (#2843) (#2862) (Simon Ho) * Fix description of updateAll response (Miroslav Bajtoš)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated based on feedback received during sprint demo.
Backport of #2865
cc @bajtos @strongloop/loopback-dev