Update test confirmation text in PR template #2897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only ask users to check when adding new tests, but some PRs only modify existing tests. Also added instructions to mark with an "x" for checking off items.
bajtos
approved these changes
Oct 26, 2016
.github/PULL_REQUEST_TEMPLATE.md
Outdated
|
|
||
| - [ ] New tests are added to cover all changes | ||
| <!-- | ||
| Please mark your choice with an "x" (eg. [x], not [*]) |
Member
There was a problem hiding this comment.
Perhaps add a link to https://github.com/blog/1375-task-lists-in-gfm-issues-pulls-comments
bajtos
added a commit
that referenced
this pull request
Dec 5, 2016
* Fix use-strict issue with connectors after merge (Loay) * Fix connector naming in strict mode (ebarault) * Add "returnOnlyRoleNames" option to Role.getRoles (Eric) * Update translation files (Candy) * Fix broken document for `upsertWithWhere` (Amir Jafarian) * Fix js doc for deleteAll event (Candy) * add allowArray to relations' create remoteMethod (David Cheung) * Remove workaround for default value (Loay) * Fix remote method example (Amir Jafarian) * Remove `example/context` (Amir Jafarian) * Turn on "no-unused-expressions" rule for eslint (Miroslav Bajtoš) * Update eslint to loopback config v5 (Loay) * Fix total calculation in example (Candy) * make test individually runable (David Cheung) * Add options to bulkUpdate (Kogulan Baskaran) * Fix context within listByPrincipalType role method (codyolsen) * Add Node v7 to Travis CI platforms (Miroslav Bajtoš) * Drop support for Node v0.10 and v0.12 (Miroslav Bajtoš) * Add templateFn option to User#verify() (Adrien Kiren) * Require verification after email change (Loay) * Update doc links (Candy) * adding check of string for case insensitive emails (Dhaval Trivedi) * Update test confirmation text in PR template (#2897) (Simon Ho) * allow batch create for persisted models (David Cheung) * Fix PR template to not link all PRs to #49 (#2887) (Miroslav Bajtoš) * Need index on principalId for performance. (#2883) (Simon Ho) * Remove redundant items in PR template (#2877) (Simon Ho) * Refactor PR template based on feedback (#2865) (Simon Ho) * Add pull request template (#2843) (Simon Ho) * Update README.md (Rand McKinney) * Reword ticking checkbox note in issue template (#2854) (Simon Ho) * Add how to tick checkbox in issue template (#2851) (Simon Ho) * Fix description of updateAll response (Miroslav Bajtoš) * Allow tokens with eternal TTL (value -1) (Miroslav Bajtoš) * Use GitHub issue templates (#2810) (Simon Ho) * Update ja and nl translation files (Candy) * Remove 3.0 DEVELOPING & RELEASE-NOTES (Miroslav Bajtoš) * Fix support for remote hooks returning a Promise (Tim van der Staaij) * Validate non-email property partial update (Loay) * Update release notes (Amir Jafarian) * Update translation files - round#2 (Candy) * Add license text (Candy) * Temporarily disable Karma tests on Windows CI (Miroslav Bajtoš)
ebarault
pushed a commit
to ebarault/loopback
that referenced
this pull request
Dec 6, 2016
* Fix use-strict issue with connectors after merge (Loay) * Fix connector naming in strict mode (ebarault) * Add "returnOnlyRoleNames" option to Role.getRoles (Eric) * Update translation files (Candy) * Fix broken document for `upsertWithWhere` (Amir Jafarian) * Fix js doc for deleteAll event (Candy) * add allowArray to relations' create remoteMethod (David Cheung) * Remove workaround for default value (Loay) * Fix remote method example (Amir Jafarian) * Remove `example/context` (Amir Jafarian) * Turn on "no-unused-expressions" rule for eslint (Miroslav Bajtoš) * Update eslint to loopback config v5 (Loay) * Fix total calculation in example (Candy) * make test individually runable (David Cheung) * Add options to bulkUpdate (Kogulan Baskaran) * Fix context within listByPrincipalType role method (codyolsen) * Add Node v7 to Travis CI platforms (Miroslav Bajtoš) * Drop support for Node v0.10 and v0.12 (Miroslav Bajtoš) * Add templateFn option to User#verify() (Adrien Kiren) * Require verification after email change (Loay) * Update doc links (Candy) * adding check of string for case insensitive emails (Dhaval Trivedi) * Update test confirmation text in PR template (strongloop#2897) (Simon Ho) * allow batch create for persisted models (David Cheung) * Fix PR template to not link all PRs to strongloop#49 (strongloop#2887) (Miroslav Bajtoš) * Need index on principalId for performance. (strongloop#2883) (Simon Ho) * Remove redundant items in PR template (strongloop#2877) (Simon Ho) * Refactor PR template based on feedback (strongloop#2865) (Simon Ho) * Add pull request template (strongloop#2843) (Simon Ho) * Update README.md (Rand McKinney) * Reword ticking checkbox note in issue template (strongloop#2854) (Simon Ho) * Add how to tick checkbox in issue template (strongloop#2851) (Simon Ho) * Fix description of updateAll response (Miroslav Bajtoš) * Allow tokens with eternal TTL (value -1) (Miroslav Bajtoš) * Use GitHub issue templates (strongloop#2810) (Simon Ho) * Update ja and nl translation files (Candy) * Remove 3.0 DEVELOPING & RELEASE-NOTES (Miroslav Bajtoš) * Fix support for remote hooks returning a Promise (Tim van der Staaij) * Validate non-email property partial update (Loay) * Update release notes (Amir Jafarian) * Update translation files - round#2 (Candy) * Add license text (Candy) * Temporarily disable Karma tests on Windows CI (Miroslav Bajtoš)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only ask users to check when adding new tests, but
some PRs only modify existing tests. Also added
instructions to mark with an "x" for checking off items.
@bajtos PTAL