Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Simplify issue template #3083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
superkhau merged 1 commit into from
Jan 12, 2017
Merged

Simplify issue template #3083

superkhau merged 1 commit into from
Jan 12, 2017

Conversation

@superkhau
Copy link
Contributor

@superkhau superkhau commented Jan 9, 2017 •
edited
Loading

Favour form editing over going down a checklist. Also fix
automatic 2 subtasks creation side effect from old issue template.

@bajtos @raymondfeng @ritch PTAL

@superkhau superkhau self-assigned this Jan 9, 2017
@superkhau superkhau force-pushed the refactor/issue-template branch 2 times, most recently from cbff5c0 to e7cc6a9 Compare January 9, 2017 21:49
raymondfeng
raymondfeng reviewed Jan 9, 2017
View reviewed changes
.github/ISSUE_TEMPLATE.md

<!-- Include actual results if bug -->

### Additional information
Copy link
Member

@raymondfeng raymondfeng Jan 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to get the output of node -e 'console.log(process.platform, process.arch,process.versions.node)'. For example: darwin x64 6.9.2.

@superkhau superkhau force-pushed the refactor/issue-template branch 2 times, most recently from 6add0dc to d71a69c Compare January 9, 2017 22:28
@superkhau
Copy link
Contributor Author

superkhau commented Jan 9, 2017

@raymondfeng Applied review comments, PTAL again.

raymondfeng
raymondfeng reviewed Jan 9, 2017
View reviewed changes
.github/ISSUE_TEMPLATE.md Outdated
### Additional information (Node.js version, LoopBack version, etc)

```shell
node -e 'console.log(process.platform, process.arch, process.versions.node)
Copy link
Member

@raymondfeng raymondfeng Jan 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the trailing '

@superkhau superkhau force-pushed the refactor/issue-template branch 2 times, most recently from bf5fd07 to 12403e0 Compare January 9, 2017 22:39
@superkhau
Copy link
Contributor Author

superkhau commented Jan 9, 2017 •
edited
Loading

@raymondfeng Fixed the missing trailing single quote, PTAL again.

@superkhau
Copy link
Contributor Author

superkhau commented Jan 9, 2017

@slnode test please

@cgole cgole removed the #review label Jan 10, 2017
@superkhau
Copy link
Contributor Author

superkhau commented Jan 10, 2017

@slnode test please

bajtos
bajtos reviewed Jan 10, 2017
View reviewed changes
.github/ISSUE_TEMPLATE.md Outdated

### Expected result

<!-- Include actual results if bug -->
Copy link
Member

@bajtos bajtos Jan 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include both expected and actual results if bug

bajtos
bajtos reviewed Jan 10, 2017
View reviewed changes
.github/ISSUE_TEMPLATE.md Outdated
```

- Above command output: <!-- Paste output of command shown above here -->
- LoopBack version: <!-- 2.x/3.x -->
Copy link
Member

@bajtos bajtos Jan 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we ask users to run npm ls --prod --depth 0 | grep loopback to show us exact versions of all loopback-related modules they are using?

Copy link
Contributor Author

@superkhau superkhau Jan 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see the harm (except windows not being able to | grep loopback). Let's give it a shot.

@bajtos
Copy link
Member

bajtos commented Jan 10, 2017

I don't have a strong opinion on these templates. FWIW, the change LGTM.

@superkhau superkhau force-pushed the refactor/issue-template branch from 12403e0 to 1696e52 Compare January 11, 2017 17:35
@superkhau @simonhoibm
Simplify issue template
31a2e99 
Favour form editing over going down a checklist. Also fix automatic 2
subtasks creation side effect from old issue template.
@superkhau superkhau force-pushed the refactor/issue-template branch from 1696e52 to 31a2e99 Compare January 11, 2017 17:36
@superkhau superkhau added this to the Sprint 27 milestone Jan 11, 2017
This was referenced Feb 13, 2017
Closed
Closed
Merged
Closed
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Closed
Merged
Merged
Merged
Merged
Closed
Merged
Closed
Closed
Merged
Closed
Merged
Merged
Merged
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raymondfeng raymondfeng raymondfeng left review comments

@ritch ritch ritch approved these changes

+1 more reviewer

@bajtos bajtos bajtos left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@superkhau superkhau

Labels

community-experience

Projects

None yet

Milestone

Sprint 27

Development

Successfully merging this pull request may close these issues.

6 participants

@superkhau @bajtos @ritch @raymondfeng @cgole