Handle missing getUpdateOnlyProperties fn #3579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the current scope does not define a getUpdateOnlyProperties function, the updateOnlyProps value will now be set to false.
jannyHou
approved these changes
Aug 23, 2017
b-admike
approved these changes
Aug 23, 2017
ssh24
approved these changes
Aug 23, 2017
|
Same problem still persists in lib/model.js:764 |
|
Same problem in lib/model.js:764. I think must be reviewed. |
Contributor
|
I agree with @BendingBender and @supermafete, the problem also exists on Line 769 in 8488da2 I will create a follow-up PR now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the current scope (
this) does not define a.getUpdateOnlyPropertiesfunction, the
updateOnlyPropsvalue will now be set to false.Related issues
Fixes regression in #3548