Add globalization #12

superkhau · 2016-07-22T06:37:33Z

Connect to strongloop/loopback/issues/2422

superkhau · 2016-07-22T06:44:38Z

@slnode test please

0candy · 2016-07-22T15:36:33Z

lib/phase-list.js


  if(!phase.__isPhase__) {
-    throw new Error('Cannot add a non phase object to a PhaseList');
+    throw new Error(g.t('Cannot add a non phase object to a PhaseList'));


Add {{}} for {{PhaseList}}

0candy · 2016-07-22T15:38:25Z

package.json

    "async": "^0.9.0",
-    "debug": "^2.1.0"
+    "debug": "^2.1.0",
+    "strong-globalize": "^2.5.5"


2.5.6 fixed the swagger-client bug you were seeing yesterday

superkhau · 2016-07-23T00:27:22Z

@0candy Updated, review again pls.

0candy · 2016-07-25T15:29:19Z

lib/phase-list.js


  if(!phase.__isPhase__) {
-    throw new Error('Cannot add a non phase object to a PhaseList');
+    throw new Error(g.t('Cannot add a non phase object to a {{PhaseList}}'));


You have to run slt-globalize -e again for intl/en/messages.json to get updated with the brackets change.

superkhau · 2016-07-25T17:12:28Z

@0candy Updated, PTAL again.

0candy · 2016-07-25T20:14:07Z

The change itself LGTM.
But there is a globalize error right now, all the CI tests fail.

  throw new assert.AssertionError({
        ^
AssertionError: Not supported: en
    at loadGlobalize (/mnt/jenkins/workspace/loopback-component-push/cdcdef7b/node_modules/strong-globalize/lib/globalize.js:354:3)
    at Object.setDefaultLanguage (/mnt/jenkins/workspace/loopback-component-push/cdcdef7b/node_modules/strong-globalize/lib/globalize.js:100:3)
    at new StrongGlobalize (/mnt/jenkins/workspace/loopback-component-push/cdcdef7b/node_modules/strong-globalize/index.js:27:41)
    at StrongGlobalize (/mnt/jenkins/workspace/loopback-component-push/cdcdef7b/node_modules/strong-globalize/index.js:25:12)
    at Object.<anonymous> (/mnt/jenkins/workspace/loopback-component-push/cdcdef7b/lib/providers/apns.js:11:9)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)

So please don't merge yet.

0candy · 2016-07-26T14:40:46Z

Please fix this too: strongloop/loopback-component-push#118 (comment)

rmg · 2016-07-27T02:36:13Z

@slnode test please

rmg · 2016-07-27T20:07:13Z

@0candy the strong-globalize problem has been resolved. This PR is now failing on one of the tests, which looks like it needs to be updated to accept the translated string:

  29 passing (54ms)
  1 failing

  1) PhaseList phaseList.addAfter throws when the "after" phase was not found:
     AssertionError: expected [Function] to throw error matching /unknown-phase/ but got 'Unknown phase: %'
      at Context.<anonymous> (test/phase-list.test.js:146:18)

0candy · 2016-07-27T20:36:44Z

@superkhau Please fix the line that @rmg pointed out. Thanks.

superkhau · 2016-07-28T20:37:58Z

@gunjpan @richardpringle PTAL, updated with latest conventions.

superkhau · 2016-07-28T22:18:38Z

@rmg Tons of unrelated failures in this PR. Can you provide some insight? It seems like some NPM registry doesn't contain loopback according to the errors.

rmg · 2016-07-29T02:14:54Z

@slnode test please

rmg · 2016-07-29T02:18:01Z

@superkhau they look like they are probably related to high load. Looking at the file dump from the ephemeral registry they were using, there were 6 partial copies of loopback mid-cache, so I think it just sort of choked on all the downstream jobs running at the same time.

On the upside, if you look at the cis-jenkins downstream jobs, those are the ones that are actually version aware, so only downstream modules that actually use this version of loopback-phase were triggered. And those all passed :-)

superkhau · 2016-07-29T06:46:01Z

On the upside, if you look at the cis-jenkins downstream jobs, those are the ones that are actually version aware, so only downstream modules that actually use this version of loopback-phase were triggered. And those all passed :-)

👍 That's a definition plus as the ones actually failing are unrelated and the ones I care about are passing on cis-jenkins. Thanks for checking, I'm gonna merge as I feel this is safe enough. ;)

gunjpan · 2016-07-29T14:42:51Z

lib/phase-list.js

  var ix = this.getPhaseNames().indexOf(after);
  if (ix === -1) {
-    throw new Error('Unknown phase: "' + after + '"');
+    throw new Error(g.f('Unknown phase: %', after));


@superkhau : this should be:
throw new Error(g.f('Unknown phase: %s', after));

gunjpan · 2016-07-29T14:54:21Z

@superkhau: Reviewed. Few nit-picks, otherwise, LGTM.

superkhau · 2016-07-30T00:25:23Z

@gunjpan @richardpringle Updated. PTAL again.

richardpringle · 2016-08-03T13:00:10Z

LGTM

superkhau added the feature label Jul 22, 2016

superkhau assigned superkhau and 0candy Jul 22, 2016

superkhau added the #review label Jul 22, 2016

0candy mentioned this pull request Jul 22, 2016

Add globalization to loopback repos [placeholder] strongloop/loopback#2422

Closed

63 tasks

0candy reviewed Jul 22, 2016
View reviewed changes

0candy removed their assignment Jul 22, 2016

0candy reviewed Jul 22, 2016
View reviewed changes

superkhau force-pushed the globalization branch from 1761ebd to 072a992 Compare July 23, 2016 00:26

superkhau assigned 0candy and unassigned superkhau Jul 23, 2016

0candy reviewed Jul 25, 2016
View reviewed changes

superkhau force-pushed the globalization branch from 072a992 to 717ac72 Compare July 25, 2016 17:12

0candy assigned superkhau and unassigned 0candy Jul 27, 2016

superkhau force-pushed the globalization branch 2 times, most recently from 817b3fa to bcf77a4 Compare July 28, 2016 20:36

superkhau assigned gunjpan and richardpringle Jul 28, 2016

gunjpan reviewed Jul 29, 2016
View reviewed changes

superkhau force-pushed the globalization branch from bcf77a4 to 75f0e3e Compare July 30, 2016 00:24

Add globalization

0ffb00f

superkhau force-pushed the globalization branch from 75f0e3e to 0ffb00f Compare August 4, 2016 07:58

superkhau merged commit a306815 into master Aug 4, 2016

superkhau deleted the globalization branch August 4, 2016 07:59

superkhau removed the #review label Aug 4, 2016

richardpringle removed their assignment Aug 10, 2016

Add globalization #12

Add globalization #12

Uh oh!

Conversation

superkhau commented Jul 22, 2016

Uh oh!

superkhau commented Jul 22, 2016

Uh oh!

0candy Jul 22, 2016

Choose a reason for hiding this comment

Uh oh!

0candy Jul 22, 2016

Choose a reason for hiding this comment

Uh oh!

superkhau commented Jul 23, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0candy Jul 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

superkhau commented Jul 25, 2016

Uh oh!

0candy commented Jul 25, 2016

Uh oh!

0candy commented Jul 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rmg commented Jul 27, 2016

Uh oh!

rmg commented Jul 27, 2016

Uh oh!

0candy commented Jul 27, 2016

Uh oh!

superkhau commented Jul 28, 2016

Uh oh!

superkhau commented Jul 28, 2016

Uh oh!

rmg commented Jul 29, 2016

Uh oh!

rmg commented Jul 29, 2016

Uh oh!

superkhau commented Jul 29, 2016

Uh oh!

gunjpan Jul 29, 2016

Choose a reason for hiding this comment

Uh oh!

gunjpan commented Jul 29, 2016

Uh oh!

superkhau commented Jul 30, 2016

Uh oh!

richardpringle commented Aug 3, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

superkhau commented Jul 23, 2016 •

edited

Loading

0candy Jul 25, 2016 •

edited

Loading

0candy commented Jul 26, 2016 •

edited

Loading