Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Overdrivr
Copy link
Contributor

Description

Backport of #385

Related issues

Checklist

@slnode
Copy link

slnode commented Jan 7, 2017

Can one of the admins verify this patch?

2 similar comments
@slnode
Copy link

slnode commented Jan 7, 2017

Can one of the admins verify this patch?

@slnode
Copy link

slnode commented Jan 7, 2017

Can one of the admins verify this patch?

@bajtos
Copy link
Member

bajtos commented Jan 9, 2017

The change in lib looks like a straightforward backport of the change from the master, which is good! I'll leave the detailed review to @gunjpan though.

@Overdrivr could you please rebase your patch on top of the latest 2.x branch to satisfy the "PR Linter" check, which is currently failing?

@Overdrivr
Copy link
Contributor Author

@bajtos @gunjpan Rebase done and all checks passing, ready for review

@bajtos bajtos merged commit 0d8173c into strongloop:2.x Jan 10, 2017
@bajtos
Copy link
Member

bajtos commented Jan 10, 2017

Landed, thank you for the contribution!

@gunjpan
Copy link
Contributor

gunjpan commented Jan 10, 2017

@bajtos : It was straight forward backport, but couldn't get to review due to priorities. Thank you for chiming in 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants