Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: 搜索异常时导致页面渲染异常, 搜索框 XSS 漏洞 #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2021
Merged

fix: 搜索异常时导致页面渲染异常, 搜索框 XSS 漏洞 #158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions http/controller/search.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package controller

import (
"html"

"github.com/studygolang/studygolang/context"
"github.com/studygolang/studygolang/logic"

Expand Down Expand Up @@ -31,11 +33,12 @@ func (SearchController) Search(ctx echo.Context) error {
"q": q,
"f": field,
}
if err == nil {
uri := "/search?q=" + q + "&f=" + field + "&"
paginator := logic.NewPaginatorWithPerPage(p, rows)
data["pageHtml"] = paginator.SetTotal(int64(respBody.NumFound)).GetPageHtml(uri)
if err != nil {
return render(ctx, "500.html", nil)
}
uri := "/search?q=" + html.EscapeString(q) + "&f=" + field + "&"
paginator := logic.NewPaginatorWithPerPage(p, rows)
data["pageHtml"] = paginator.SetTotal(int64(respBody.NumFound)).GetPageHtml(uri)

return render(ctx, "search.html", data)
}
Expand All @@ -60,11 +63,12 @@ func (SearchController) TagList(ctx echo.Context) error {
"users": users,
"nodes": nodes,
}
if err == nil {
uri := "/tag/" + q + "?"
paginator := logic.NewPaginatorWithPerPage(p, rows)
data["pageHtml"] = paginator.SetTotal(int64(respBody.NumFound)).GetPageHtml(uri)
if err != nil {
return render(ctx, "500.html", nil)
}
uri := "/tag/" + q + "?"
paginator := logic.NewPaginatorWithPerPage(p, rows)
data["pageHtml"] = paginator.SetTotal(int64(respBody.NumFound)).GetPageHtml(uri)

return render(ctx, "feed/tag.html", data)
}