fix: respect user's default snacks picker layout preset #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously base_picker hardcoded the layout preset to 'default' or 'select' based on whether preview was enabled. This meant user-configured presets (ivy/telescope/default/select) were not respected for non-file pickers. Remove the hardcoded preset to let Snacks use the user's default preference, matching the behavior of the file picker.
- ensures proper handling when preview is not enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
configfunc doesn't have an expected return typetitlefromPickerOption string|fun()is converted to astring?which the Snacks picker exptectsfalsein Snacks to prevent errors when the global default config has preview enabled