📝(contributing) update contributing policy #1192
Conversation
.github/ISSUE_TEMPLATE/Bug_report.md
Outdated
|
|
||
| **Before you file your issue** | ||
| - Check the other [issues](https://github.com/suitenumerique/docs/issues) before filing your own | ||
| - If your issue is related to the text editor ([BlockNote](https://github.com/TypeCellOS/BlockNote)) please [file it on their repo](https://github.com/TypeCellOS/BlockNote/issues). If you don't know file away ! We'll tell you where it belongs or even file it for you if we need it too 😊 |
There was a problem hiding this comment.
I suggest rephrasing the second item: "If your report is related to the BlockNote text editor, file it on their repo. If you're not sure whether the problem is with BlockNote or Docs, file the bug on our repo: if we support it, we'll backport it upstream ourselves, otherwise we'll ask you to do so."
If you keep the current phrasing, just a nitpick: you can remove the space before the "!".
There was a problem hiding this comment.
We are using this template (PULL_REQUEST_TEMPLATE.md), it should not be removed.
fd2af80 to
e2dcc50
Compare
There was a problem hiding this comment.
You have a typo in your commit message:
- 📝(contributing) udpate issue template
+ 📝(contributing) update issue templateThis commit (📝(contributing) BlockNote instructions) is a fixup of this commit (📝(contributing) udpate issue template), they should be squashed.
We get issues that are actually for BlockNote Signed-off-by: virgile-dev <[email protected]>
The template removed is no longer in use Signed-off-by: virgile-dev <[email protected]>
e2dcc50 to
54199ec
Compare
Purpose
Update the issue template to help contributors
Please ensure the following items are checked before submitting your pull request:
git commit --signoff(DCO compliance)git commit -S)<gitmoji>(type) title description## [Unreleased]section (if noticeable change)