Add support for DescendantProviderInterface for pages #8345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2e352a3 to
223f318
Compare
Comment on lines
46
to
49
| private AccessControlRepositoryInterface $accessControlRepository, | ||
| private SystemStoreInterface $systemStore, | ||
| private ?Security $security, | ||
| private array $permissions, |
Member
There was a problem hiding this comment.
Unsure handle this in the application layer as its unrelated to page domain, as security is more related to UserInterface or Infrastracture Layer 🤔 .
Member
Author
There was a problem hiding this comment.
Unsure handle this in the application layer as its unrelated to page domain, as security is more related to UserInterface or Infrastracture Layer 🤔 .
Yeah, I wasn’t completely sure about it either. It also feels a bit odd in the controller.
Member
There was a problem hiding this comment.
as discussed we move to request listener
# Conflicts: # packages/page/src/Infrastructure/Symfony/HttpKernel/SuluPageBundle.php
15da48b to
6162229
Compare
alexander-schranz
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR implements
DescendantProviderInterfacesupport for pages, adding:force=trueto proceed)findDescendantIdsById()method in PageRepository for querying page hierarchiesWhy?
Missing feature from Sulu 3.0