Thanks to visit codestin.com
Credit goes to github.com

Add example to show how to overlay off-disk contours from one map onto another map#8012

Merged

nabobalis merged 44 commits into

tanishy7777:new_example

Feb 20, 2025

Contributor

tanishy7777 commented Jan 14, 2025 •

edited

Loading

Fixes: #6506

Adds example to show that SphericalScreen can be used even without reprojection.

assume_spherical_screen seems to be deprecated and even the current examples in the example gallery seem to be using
sunpy.coordinates.screens.SphericalScreen and they do seem to be used with reprojection only. (#6506 (comment))


          Adds new example for example gallery

ed7bcb0

tanishy7777 requested a review from a team as a code owner

January 14, 2025 15:28

tanishy7777 and others added 3 commits

January 14, 2025 21:00


          Adds changelog

ac634ed


          Merge branch 'main' into new_example

83ad340


          Merge branch 'main' into new_example

d36ba40

nabobalis reviewed

View reviewed changes

changelog/8012.doc.rst Outdated

nabobalis reviewed

View reviewed changes

examples/plotting/add_countour_with_Spherical_screen.py Outdated

nabobalis reviewed

View reviewed changes

examples/plotting/add_countour_with_Spherical_screen.py Outdated

nabobalis reviewed

View reviewed changes

examples/plotting/add_countour_with_Spherical_screen.py Outdated

nabobalis reviewed

View reviewed changes

examples/plotting/add_countour_with_Spherical_screen.py Outdated

nabobalis reviewed

View reviewed changes

examples/plotting/add_countour_with_Spherical_screen.py Outdated

tanishy7777 and others added 2 commits

January 14, 2025 22:34


          Update examples/plotting/add_countour_with_Spherical_screen.py

e690267

Co-authored-by: Nabil Freij <[email protected]>


          Update examples/plotting/add_countour_with_Spherical_screen.py

f1c644a

Co-authored-by: Nabil Freij <[email protected]>

nabobalis reviewed

View reviewed changes

examples/plotting/add_countour_with_Spherical_screen.py Outdated

nabobalis reviewed

View reviewed changes

examples/plotting/add_countour_with_Spherical_screen.py Outdated

nabobalis reviewed

View reviewed changes

examples/plotting/add_countour_with_Spherical_screen.py Outdated

nabobalis marked this pull request as draft

January 14, 2025 17:06

nabobalis added Examples Documentation backport 6.0 and removed backport 6.0 labels


          Merge branch 'sunpy:main' into new_example

d686f05

nabobalis reviewed

View reviewed changes

examples/plotting/add_countour_with_Spherical_screen.py Outdated

tanishy7777 and others added 4 commits

January 16, 2025 22:56


          interlink to the gallery example

ccf102b


          Adds without sphericalscreeen

6d54b7a


          Rename add_countour_with_spherical_screen.py to add_countour_with_sph…

5beed7f

…erical_screen.py


          Merge branch 'main' into new_example

79f63ee

nabobalis requested a review from wtbarnes

January 16, 2025 18:11

nabobalis reviewed

View reviewed changes

changelog/8012.doc.rst Outdated

ayshih changed the title ~~Add example to show that SphericalScreen can be used even without reprojection~~ Add example to show how to overlay off-disk contours from one map onto another map

tanishy7777 and others added 6 commits

February 19, 2025 03:43


          Update examples/plotting/add_countour_with_spherical_screen.py

e9b09bb

Co-authored-by: Albert Y. Shih <[email protected]>


          Update examples/plotting/add_countour_with_spherical_screen.py

5d3d47d

Co-authored-by: Albert Y. Shih <[email protected]>


          Update examples/plotting/add_countour_with_spherical_screen.py

c9c2675

Co-authored-by: Albert Y. Shih <[email protected]>


          Update changelog/8012.doc.rst

96be280

Co-authored-by: Albert Y. Shih <[email protected]>


          Update examples/plotting/add_countour_with_spherical_screen.py

c84cb4e

Co-authored-by: Albert Y. Shih <[email protected]>


          Rename add_countour_with_spherical_screen.py to offdisk_contours.py

2db50b1

Contributor Author

tanishy7777 commented Feb 18, 2025

I've overhauled the example, including splitting the plot into three plots. Please also rename the example file to offdisk_contours.py.

I have renamed it to offdisk_contours.py

nabobalis requested review from ayshih and removed request for wtbarnes

February 18, 2025 22:18

nabobalis reviewed

View reviewed changes

examples/plotting/offdisk_contours.py Outdated

nabobalis reviewed

View reviewed changes

examples/plotting/offdisk_contours.py Outdated

nabobalis reviewed

View reviewed changes

examples/plotting/offdisk_contours.py Outdated

nabobalis reviewed

View reviewed changes

examples/plotting/offdisk_contours.py Outdated

nabobalis reviewed

View reviewed changes

examples/plotting/offdisk_contours.py Outdated

nabobalis reviewed

View reviewed changes

examples/plotting/offdisk_contours.py Outdated

nabobalis reviewed

View reviewed changes

examples/plotting/offdisk_contours.py Outdated

nabobalis reviewed

View reviewed changes

examples/plotting/offdisk_contours.py Outdated

tanishy7777 and others added 8 commits

February 19, 2025 04:03


          Update examples/plotting/offdisk_contours.py

1457d64

Co-authored-by: Nabil Freij <[email protected]>


          Update examples/plotting/offdisk_contours.py

c71b97c

Co-authored-by: Nabil Freij <[email protected]>


          Update examples/plotting/offdisk_contours.py

25f9f10

Co-authored-by: Nabil Freij <[email protected]>


          Update examples/plotting/offdisk_contours.py

5bf62eb

Co-authored-by: Nabil Freij <[email protected]>


          Update examples/plotting/offdisk_contours.py

88d0f93

Co-authored-by: Nabil Freij <[email protected]>


          Update examples/plotting/offdisk_contours.py

4dfb14e

Co-authored-by: Nabil Freij <[email protected]>


          Update examples/plotting/offdisk_contours.py

34d3ed0

Co-authored-by: Nabil Freij <[email protected]>


          Update examples/plotting/offdisk_contours.py

e80fb58

Co-authored-by: Nabil Freij <[email protected]>

ayshih approved these changes

View reviewed changes

Member

ayshih left a comment •

edited

Loading

Looks good to me!

Note to merger: please squash

nabobalis approved these changes

View reviewed changes

nabobalis merged commit 266a324 into sunpy:main

Member

nabobalis commented Feb 20, 2025

Thanks again @tanishy7777 and @ayshih

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Examples No Backport