Thanks to visit codestin.com
Credit goes to github.com

Skip to content

deprecate sunpy.physics.solar_rotate_coordinate and sunpy.physics.differential_rotate.#8039

Draft
ankitkhushwaha wants to merge 2 commits into
sunpy:mainfrom
ankitkhushwaha:deprecate
Draft

deprecate sunpy.physics.solar_rotate_coordinate and sunpy.physics.differential_rotate.#8039
ankitkhushwaha wants to merge 2 commits into
sunpy:mainfrom
ankitkhushwaha:deprecate

Conversation

@ankitkhushwaha
Copy link
Copy Markdown
Contributor

@ankitkhushwaha ankitkhushwaha commented Jan 25, 2025 •
edited
Loading

PR Description

fixes #7161

  • deprecated sunpy.physics.solar_rotate_coordinate and sunpy.physics.differential_rotate
  • added tests for deprecation
  • moved solar_rotate_coordinate() to sunpy.coordinates.utils as solar_coordinate_rotation
  • moved differential_rotate() to sunpy.map.maputils as diff_rotation
  • moved required tests
  • added changelog

@ankitkhushwaha ankitkhushwaha requested review from a team as code owners January 25, 2025 18:18
@nabobalis nabobalis requested a review from ayshih January 25, 2025 18:27
@ankitkhushwaha ankitkhushwaha force-pushed the deprecate branch 5 times, most recently from 94073c9 to 59aa36b Compare January 26, 2025 08:13
@ankitkhushwaha ankitkhushwaha force-pushed the deprecate branch 2 times, most recently from b2ecac4 to f8d84e5 Compare February 4, 2025 17:53
@nabobalis nabobalis added coordinates Affects the coordinates submodule No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) labels Feb 8, 2025
@nabobalis nabobalis added this to the 7.0.0 milestone Feb 11, 2025
wtbarnes
wtbarnes requested changes Apr 9, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@wtbarnes wtbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to address the stated issue, this PR should also deprecate and move diff_rot to sunpy.sun.models. Additionally, the names of solar_rotate_coordinate and differential_rotate functions should be preserved when moving and deprecating.

@ankitkhushwaha
Copy link
Copy Markdown
Contributor Author

ankitkhushwaha commented Apr 14, 2025 •
edited by wtbarnes
Loading

Hey @wtbarnes, Pr #7409 already moved diff_rot to sunpy.sun.models.

@wtbarnes
Copy link
Copy Markdown
Member

wtbarnes commented Apr 30, 2025

Hey @wtbarnes, Pr #7409 already moved diff_rot to sunpy.sun.models.

Ah yes, you're right. My mistake!

@Cadair Cadair removed this from the 7.0.0 milestone May 14, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 12, 2025

Hello 👋, Thanks for your contribution to sunpy!
I have marked this pull request as stale because there hasn't had any activity in five months. If you are still working on this, or if it's waiting on a maintainer to look at it then please let us know and we will keep it open. Please add a comment with: @sunpy/sunpy-developers to get someone's attention.
If nobody comments on this pull request for another month, it will be closed.

@github-actions github-actions Bot added the Stale The bot will close this PR after 6 months (if enabled on this repo). label Oct 12, 2025
Cadair
Cadair reviewed Oct 29, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Cadair Cadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ankitkhushwaha Sorry it's taken me so long to review this. It looks like some changes have caused major conflicts in the moved tests.

Do you want to finish this PR off or should we close it?

Comment thread changelog/8039.deprecation.rst
Comment on lines +1 to +2
:func:`sunpy.physics.differential_rotation.solar_rotate_coordinate` has been deprecated and replaced by :func:`sunpy.coordinates.utils.solar_coordinate_rotation` and
:func:`sunpy.physics.differential_rotation.differential_rotate` has been deprecated and replaced by :func:``sunpy.map.maputils.diff_rotation``.
Copy link
Copy Markdown
Member

@Cadair Cadair Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the motivation for the renames of these functions rather than just the moves? I'm +0 on solar_coordinate_rotation but I am -1 on diff_rotation?

Comment thread docs/reference/coordinates/index.rst

.. automodapi:: sunpy.coordinates.utils
:no-inheritance-diagram:
:skip: get_new_observer
Copy link
Copy Markdown
Member

@Cadair Cadair Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have we renamed this function from _get_new_observer to get_new_observer but then chosen to not document it? Why don't we just keep it private?

@Cadair Cadair marked this pull request as draft October 29, 2025 12:56
@github-actions github-actions Bot removed the Stale The bot will close this PR after 6 months (if enabled on this repo). label Oct 30, 2025
@ankitkhushwaha
Copy link
Copy Markdown
Contributor Author

ankitkhushwaha commented Nov 7, 2025

Do you want to finish this PR off or should we close it?

hey @Cadair, give me sometime i will finish this soon.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 27, 2026

Hello 👋, Thanks for your contribution to sunpy!
I have marked this pull request as stale because there hasn't had any activity in five months. If you are still working on this, or if it's waiting on a maintainer to look at it then please let us know and we will keep it open. Please add a comment with: @sunpy/sunpy-developers to get someone's attention.
If nobody comments on this pull request for another month, it will be closed.

@github-actions github-actions Bot added the Stale The bot will close this PR after 6 months (if enabled on this repo). label Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cadair Cadair Cadair left review comments

@wtbarnes wtbarnes wtbarnes requested changes

@ayshih ayshih Awaiting requested review from ayshih

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

coordinates Affects the coordinates submodule No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) Stale The bot will close this PR after 6 months (if enabled on this repo).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Divide up and remove sunpy.physics.differential_rotation

4 participants

@ankitkhushwaha @wtbarnes @Cadair @nabobalis