Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed the introspection of our own requirements#8294

Merged
nabobalis merged 1 commit into
sunpy:mainfrom
ayshih:get_requirements
Jul 7, 2025
Merged

Fixed the introspection of our own requirements#8294
nabobalis merged 1 commit into
sunpy:mainfrom
ayshih:get_requirements

Conversation

@ayshih
Copy link
Copy Markdown
Member

@ayshih ayshih commented Jul 3, 2025

Since 6.0, sunpy.util.system_info() stopped reporting on our optional dependencies because it couldn't resolve our nested group requirements. I don't know if this implementation is the best way to do it, but it works.

Before this PR:

>>> import sunpy
>>> sunpy.util.system_info()
==============================
sunpy Installation Information
==============================

General
#######
OS: Windows 11 10.0.26100
Arch: 64bit, (Intel64 Family 6 Model 85 Stepping 7, GenuineIntel)
sunpy: 6.1.dev119+g7259b5058.d20240911
Installation path: C:\Users\ayshih\AppData\Local\mambaforge\envs\py312\Lib\site-packages\sunpy-6.1.dev119+g7259b5058.d20240911.dist-info

Required Dependencies
#####################
astropy: 7.0.0.dev810+gb982985335.d20240911
numpy: 2.1.1
packaging: 24.1
parfive: 2.1.0
pyerfa: 2.0.1.4
requests: 2.32.3

Optional Dependencies
#####################
sunpy: 6.1.dev119+g7259b5058.d20240911

After this PR:

>>> import sunpy
>>> sunpy.util.system_info()
==============================
sunpy Installation Information
==============================

General
#######
OS: Windows 11 10.0.26100
Arch: 64bit, (Intel64 Family 6 Model 85 Stepping 7, GenuineIntel)
sunpy: 6.1.dev119+g7259b5058.d20240911
Installation path: C:\Users\ayshih\AppData\Local\mambaforge\envs\py312\Lib\site-packages\sunpy-6.1.dev119+g7259b5058.d20240911.dist-info

Required Dependencies
#####################
astropy: 7.0.0.dev810+gb982985335.d20240911
numpy: 2.1.1
packaging: 24.1
parfive: 2.1.0
pyerfa: 2.0.1.4
requests: 2.32.3

Optional Dependencies
#####################
asdf-astropy: 0.6.1
beautifulsoup4: 4.12.3
cdflib: 1.3.1
drms: 0.8.0
glymur: 0.13.6
h5netcdf: 1.3.0
h5py: 3.11.0
lxml: 5.3.0
matplotlib: 3.9.2
mpl-animators: 1.2.3
opencv-python: 4.10.0
pandas: 2.2.2
python-dateutil: 2.9.0
reproject: 0.14.0
scipy: 1.14.1
spiceypy: 6.0.0
tqdm: 4.66.5
zeep: 4.2.1

@ayshih ayshih added util Issues relating to sunpy.util backport 7.0 on-merge: backport to 7.0 labels Jul 3, 2025
@nabobalis nabobalis added the Minor Change PR only needs one approval to merge. label Jul 3, 2025
@nabobalis
Copy link
Copy Markdown
Member

nabobalis commented Jul 3, 2025

Changelog please

@Cadair
Copy link
Copy Markdown
Member

Cadair commented Jul 7, 2025

Do we not have tests for this?

@ayshih
Copy link
Copy Markdown
Member Author

ayshih commented Jul 7, 2025

This is draft because other functions in the module still aren't working correctly, and yes, tests need to be added.

@ayshih ayshih force-pushed the get_requirements branch from 0c4a486 to 3cdd23c Compare July 7, 2025 13:48
@ayshih ayshih force-pushed the get_requirements branch from 3cdd23c to b128847 Compare July 7, 2025 13:50
@ayshih
Copy link
Copy Markdown
Member Author

ayshih commented Jul 7, 2025

Okay, good to go now, with tests

@ayshih ayshih marked this pull request as ready for review July 7, 2025 13:51
@Cadair
Copy link
Copy Markdown
Member

Cadair commented Jul 7, 2025

I was more surprised we didn't have tests which failed when you changed stuff.

@nabobalis nabobalis merged commit 44260b4 into sunpy:main Jul 7, 2025
28 of 30 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/sunpy that referenced this pull request Jul 7, 2025
@nabobalis @meeseeksmachine
Backport PR sunpy#8294: Fixed the introspection of our own requirements
0f76f7c
@meeseeksmachine meeseeksmachine mentioned this pull request Jul 7, 2025
Merged
@ayshih ayshih deleted the get_requirements branch February 24, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cadair Cadair Cadair approved these changes

+1 more reviewer

@nabobalis nabobalis nabobalis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport 7.0 on-merge: backport to 7.0 Minor Change PR only needs one approval to merge. util Issues relating to sunpy.util

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ayshih @nabobalis @Cadair