Fix inconsistent behaviour between local and remote scraper searches#8316
Merged
Conversation
* Local searches crash and exit early if an expected directory does not exist * Remote searches handle these kind of error and continue * This PR adds the same functionality to local searches
ea118a3 to
f429683
Compare
samaloney
commented
Aug 8, 2025
samaloney
commented
Aug 8, 2025
| if self._check_timerange(fullpath, timerange): | ||
| filepaths.append(fullpath) | ||
| except FileNotFoundError: | ||
| log.debug(f"Local directory not found: {directory}.") |
Member
There was a problem hiding this comment.
should this be level info so it doesn't fail quietly? or is that going to lead to spamming loads?
Member
Author
There was a problem hiding this comment.
I took the same approach as in the other clients with debug messages so if we were to change it here should probably change in the other clients too?
CyclingNinja
approved these changes
Aug 22, 2025
nabobalis
approved these changes
Aug 22, 2025
meeseeksmachine
pushed a commit
to meeseeksmachine/sunpy
that referenced
this pull request
Aug 22, 2025
…remote scraper searches
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Closes #8315