REF: move coordinate-only helper and functions from maputils to coordinate.utils#8470
Open
Sankar-Konduri wants to merge 16 commits into
Open
REF: move coordinate-only helper and functions from maputils to coordinate.utils#8470Sankar-Konduri wants to merge 16 commits into
Sankar-Konduri wants to merge 16 commits into
Conversation
Author
|
All required CI checks are now passing, and this PR is ready for review when you have time.
Thanks for taking a look. |
Contributor
|
Hello 👋, Thanks for your contribution to sunpy! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This PR moves
solar_angular_radiusandcoordinate_is_on_solar_diskfromsunpy.map.maputilstosunpy.coordinates.utils, as these functions operatepurely on coordinates and do not require a Map object.
Changes included:
_verify_coordinate_helioprojectivehelper function incoordinates.utilsandreuses it in
maputilsfor existing functions.computing the solar angular radius using geometry and Astropy units in
solar_angular_radiusfunction.maputils.All relevant maputils and coordinates tests pass locally.
Closes #8445