feat: update rust to 1.84.0 and related needed changes #1590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+30
to
+32
| PGPORT = toString (5430 + | ||
| (if builtins.match ".*_.*" postgresql.version != null then 1 else 0) + # +1 for OrioleDB | ||
| ((builtins.fromJSON (builtins.substring 0 2 postgresql.version)) - 15) * 2); # +2 for each major version |
There was a problem hiding this comment.
Hm, this is confusing. Why does pg_graphql needs to know anything about the PGPORT?
There was a problem hiding this comment.
@steve-chavez its part of the pgrx build process and so needs to be handled first every pgrx extension at build time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
needed to run
nix flake update rust-overlayto bring on the code that would make rust 1.84.0 available to the nix build (this command updated just that rust-overlay input for theflake.lockfile.)Then, due to port conflicts on extension that rely on rust for pgrx builds, updating the input triggered a rebuild of other pg extensions (although did not change their dependencies, but it will always rebuild if inputs change version in any way). This created port conflicts for the internal tests the extensions run. So I applied a port handling to pg_graphql as well to fix that issue.