feat: prevent deleting storage schema rows via direct SQL query #817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 20471568146Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
What is the current behavior?
Rows can be accidentally deleted from the storage schema tables which can cause problems. Most commonly users remove rows from the storage.objects table resulting in orphan objects that cannot be removed.
What is the new behavior?
Use statement level trigger to reject any DELETE operation that does not include
storage.can_delete=truein the current settings. This allows the storage API to still remove rows while preventing deletes via direct SQL queries.This can still be bypassed by directly setting the can_delete config, but this should prevent accidental deletes and eliminate the most common cause of orphan objects