Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Joshen/fe 3213 make rls tester feedback callout more obvious #45820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshenlim wants to merge 3 commits into
base: master
Choose a base branch
from
+19 −3
Open

Joshen/fe 3213 make rls tester feedback callout more obvious #45820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5838b3
Use type default + add icon for feedback button in rls tester
joshenlim May 12, 2026
cf1c904
Add telemetry for rls tester run query
joshenlim May 12, 2026
95c1637
RABBIT
joshenlim May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions apps/studio/components/interfaces/Auth/RLSTester/RLSTesterSheet.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import {
SelectValue,
} from '@ui/components/shadcn/ui/select'
import { LOCAL_STORAGE_KEYS } from 'common'
import { Code } from 'lucide-react'
import { Code, ExternalLink } from 'lucide-react'
import { useEffect, useRef, useState } from 'react'
import {
Button,
Expand Down Expand Up @@ -42,6 +42,7 @@ import type { Policy } from '@/components/interfaces/Auth/Policies/PolicyTableRo
import { SIDEBAR_KEYS } from '@/components/layouts/ProjectLayout/LayoutSidebar/LayoutSidebarProvider'
import { AiAssistantDropdown } from '@/components/ui/AiAssistantDropdown'
import { FeaturePreviewBadge } from '@/components/ui/FeaturePreviewBadge'
import { useTrack } from '@/lib/telemetry/track'
import { useAiAssistantStateSnapshot } from '@/state/ai-assistant-state'
import { useRoleImpersonationStateSnapshot } from '@/state/role-impersonation-state'
import { useSidebarManagerSnapshot } from '@/state/sidebar-manager-state'
Expand All @@ -51,6 +52,7 @@ interface RLSTesterSheetProps {
}

export const RLSTesterSheet = ({ handleSelectEditPolicy }: RLSTesterSheetProps) => {
const track = useTrack()
const aiSnap = useAiAssistantStateSnapshot()
const { openSidebar } = useSidebarManagerSnapshot()
const { setRole } = useRoleImpersonationStateSnapshot()
Expand Down Expand Up @@ -103,8 +105,10 @@ export const RLSTesterSheet = ({ handleSelectEditPolicy }: RLSTesterSheetProps)
if (format === 'lib') {
if (!inferredSQL) return
await testQuery({ value: acceptUntrustedSql(inferredSQL), ...executionCallbacks })
track('rls_tester_run_query_clicked', { type: 'inferred' })
} else {
await testQuery({ value, ...executionCallbacks })
track('rls_tester_run_query_clicked', { type: 'raw' })
}
}

Expand Down Expand Up @@ -272,11 +276,10 @@ export const RLSTesterSheet = ({ handleSelectEditPolicy }: RLSTesterSheetProps)
</div>

<SheetFooter className="sm:justify-between">
<Button asChild type="text">
<Button asChild type="default" icon={<ExternalLink />}>
<a
target="_blank"
rel="noopener noreferrer"
className="text-foreground-light hover:text-foreground"
href="https://github.com/orgs/supabase/discussions/45233"
>
Give feedback
Expand Down
13 changes: 13 additions & 0 deletions packages/common/telemetry-constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3439,6 +3439,18 @@ export interface HeaderLocalVersionPopoverOpenedEvent {
groups: Partial<TelemetryGroups>
}

/**
* User ran a query in the RLS tester feature preview.
*
* @group Events
* @source studio
*/
export interface RLSTesterRunQueryClickedEvent {
action: 'rls_tester_run_query_clicked'
properties: { type: 'raw' | 'inferred' }
groups: Partial<TelemetryGroups>
}

/**
* @hidden
*/
Expand Down Expand Up @@ -3638,3 +3650,4 @@ export type TelemetryEvent =
| HeaderUserDropdownOpenedEvent
| HeaderLocalDropdownOpenedEvent
| HeaderLocalVersionPopoverOpenedEvent
| RLSTesterRunQueryClickedEvent
Loading