Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: Add Changesets #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 11, 2024
Merged

chore: Add Changesets #70

merged 13 commits into from
Oct 11, 2024

Conversation

AdrianGonz97
Copy link
Member

@AdrianGonz97 AdrianGonz97 commented Oct 8, 2024

TODO:

  • add NPM_TOKEN
  • rename packages to use the @sveltejs/ namespace
    • update their namespaces as well as changed @svelte-cli/core to @sveltejs/cli-core for now
  • add changesets github app to the repo (?)

@manuel3108
Copy link
Member

i think we discussed in the maintainer meeting that we should start in a RC mode. Does that mean that we need to use the pre mode of changesets they warn you really hard before?

@AdrianGonz97
Copy link
Member Author

sure, we can do that. i guess we'll go with using the @rc tag then?

Copy link

pkg-pr-new bot commented Oct 8, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/sveltejs/cli/sv@70

commit: d1ad449

@manuel3108
Copy link
Member

why the heck are the tests failing here?

Thinking about it, I think using the take will require all people to use npx sv@rc tag, or they will not get anything running. In that case I would vote for leaving it as is, and just start with the 0.5.0 we have currently setup.

@manuel3108 manuel3108 mentioned this pull request Oct 10, 2024
24 tasks
@AdrianGonz97
Copy link
Member Author

why the heck are the tests failing here?

it happens if we try to bundle ast-tooling into core. not sure why, but since we're going to bundle everything into sv for now, i've reverted that change. it'll be something we can figure out later

@benmccann benmccann merged commit f623590 into main Oct 11, 2024
5 checks passed
@benmccann benmccann deleted the chore/add-changesets branch October 11, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants