Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: remove runsAfter #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2024
Merged

chore: remove runsAfter #86

merged 1 commit into from
Oct 11, 2024

Conversation

benmccann
Copy link
Member

continuing to incrementally tackle #85

runsAfter seems like it's a duplicate of dependsOn and we can just use one of the two

Copy link

pkg-pr-new bot commented Oct 11, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/sveltejs/cli/@svelte-cli/ast-tooling@86
pnpm add https://pkg.pr.new/sveltejs/cli/sv@86
pnpm add https://pkg.pr.new/sveltejs/cli/@svelte-cli/core@86

commit: ff049c3

@AdrianGonz97
Copy link
Member

These are not the same.

runsAfter only guarantees the execution order. This does not mean that the specified adder is always executed. In other words, if adder A specifies adder B in runsAfter, then IF adder B is a selected adder, it will run before adder A.

dependsOn adds a dependency onto another adder. This means that the specified adder will always be executed. So if adder A specifies adder B in dependsOn, then every time adder A is selected, adder B will also be executed even when it hasn't been selected.

@AdrianGonz97
Copy link
Member

AdrianGonz97 commented Oct 11, 2024

I realize that we're not using runsAfter anywhere anymore. We used to need it for the eslint and prettier adder (don't remember which of the two specified it), but I guess it wasn't needed. I'm fine with removing runsAfter and adding it back if it's needed in the future.

Copy link
Member

@manuel3108 manuel3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add @AdrianGonz97 mentioned everything

@manuel3108 manuel3108 merged commit f401ccc into main Oct 11, 2024
5 checks passed
@manuel3108 manuel3108 deleted the runsAfter branch October 11, 2024 04:37
This was referenced Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants