-
-
Notifications
You must be signed in to change notification settings - Fork 36
chore: simplify adder interface #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
commit: |
This looks like a huge diff, but it really isn't. It's probably better to have a look at individual commits here, as most of the diff is just file renames. This is basically what I have done
I also considered removing the logos entirely, but i think they might be something to have in the docs at some point. Edit: Oh and I did try to inline the options of the adders that actually have options, but that was throwing me type errors that i wasn't able to figure out. We can always improve that later. |
Can confirm that this fixes #88 |
Relates #85 , but does not close it.
Goal here is to provide a simpler adder interface, without touching the actual content manipulation.
current decisions, feel free to obey:
keepremoved, now that they are all calledlogo
property and logo file, i imagine they could really add a benefit to the docslogo.(svg|webp)
id
property, asdependsOn
andrunsAfter
depend on it. we could change that to use the adder name instead, but that would probably lead to more mistakes as name is changed easier / more often than an id. We could elaborate if it's possible to provide a reference to the adder instead, (if we leave out the community adders for now, see Get rid of the--community
flag #84)tbd