Generate TypeScript declarations #134
Conversation
|
That's great! Definitely nice to get rid of that separate build step. Should we maybe add a comment in the |
|
Ok, I added a TODO to the two that are still using I didn't add a comment explaining why we're using |
|
Fine for me, but you should then maybe squash this merge and add a more descriptive commit message on why these changes were made - essentially copying most of what you write in the PR. |
|
On that note, I would love if that were mostly addressed by having PRs themselves squashed as part of merging them. Unfortunately, Rich is physically incapable of remembering to do this unless the 'create a merge commit' way of merging has been disabled for a repo. I imagine most people would be fine if I changed that setting. |
18d5c70 to
6ff5a3a
Compare
|
Yes please 😄 |
|
Ok, I updated the commit message as suggested. I was originally sending this PR against #121, but just updated it to go against I have no objection to squashing by default / removing the merge commit option |
…nerate type declarations (.d.ts) with @rollup/plugin-typescript
6ff5a3a to
8638021
Compare
@ehrencrona I'm sending this PR against your branch in #121
This builds the type declarations when you build the project
This uses
rollup-plugin-typescript2in some subprojects and@rollup/plugin-typescriptin others, which probably isn't ideal, but works well enough for now.I couldn't get
@rollup/plugin-typescriptto generate the types. I'm not exactly sure why, but rollup/plugins#247 might be related. I find@rollup/plugin-typescriptto be so full of issues I try to avoid it as much as I canrollup-plugin-typescript2generated the type declarations without problem once I realized we had"emitDeclarationOnly": trueand removed that so that it generated the.jsfiles. It didn't work on a couple of the adapters, so they haven't been switched. The error message was unclear. We should file a bug to request a better error message. I was wondering if it was because of therequirestatements inadapter-netlifyand perhaps TypeScript was expectingimportstatements insteadYou should check that this works end-to-end and gets picked up by the other sub-projects. I wasn't quite sure how to test that all the pieces fit together