Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: form.for(id) now implicitly sets id on form object #14623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rich-Harris merged 6 commits into from
Oct 7, 2025
Merged

feat: form.for(id) now implicitly sets id on form object #14623

Rich-Harris merged 6 commits into from
Oct 7, 2025

Conversation

@dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Oct 6, 2025 •
edited
Loading

wondering if we should add docs for this, I thought we had some but apparently not

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 1bf217b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

svelte-docs-bot bot commented Oct 6, 2025

Preview: https://svelte-dev-git-preview-kit-14623-svelte.vercel.app/

@Rich-Harris
Copy link
Member

Rich-Harris commented Oct 6, 2025

made a couple tweaks: if the schema has e.g. v.number(), for(...) must take a number (and same for v.string()), and the type of the id is preserved rather than always being a string

@Rich-Harris Rich-Harris merged commit b6d6b8a into main Oct 7, 2025
22 checks passed
@Rich-Harris Rich-Harris deleted the form-for-id branch October 7, 2025 00:05
@github-actions github-actions bot mentioned this pull request Oct 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rich-Harris Rich-Harris Rich-Harris approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dummdidumm @Rich-Harris