Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adjust boundary error message #16748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 70 commits into
base: main
Choose a base branch
from
Open

Adjust boundary error message #16748

wants to merge 70 commits into from
+2,344 −785

Conversation

elliott-with-the-longest-name-on-github
Copy link
Contributor

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@elliott-with-the-longest-name-on-github
feat: First pass at payload
d7f5d86
@elliott-with-the-longest-name-on-github
Merge remote-tracking branch 'origin/main' into elliott/async-ssr
f0e4672
@elliott-with-the-longest-name-on-github
first crack
c5b639c
@elliott-with-the-longest-name-on-github
snapshots
0cb6212
@elliott-with-the-longest-name-on-github
checkpoint
866a11c
@elliott-with-the-longest-name-on-github
fix: cloning
6bf1442
@elliott-with-the-longest-name-on-github
add test option
3ba2512
@elliott-with-the-longest-name-on-github
big dumb
4ffb8c9
@elliott-with-the-longest-name-on-github
today's hard work; few tests left to fix
ba95b56
@elliott-with-the-longest-name-on-github
improve
9802fd4
@elliott-with-the-longest-name-on-github
tests passing no wayyyyy yo
df67afe
@elliott-with-the-longest-name-on-github
lots of progress, couple of failing tests around selects
e39b4b7
@elliott-with-the-longest-name-on-github
meh
51392be
@elliott-with-the-longest-name-on-github
solve async tree stuff
d761749
@elliott-with-the-longest-name-on-github
fix select/option stuff
259d286
@elliott-with-the-longest-name-on-github
whoop, tests
835101b
@elliott-with-the-longest-name-on-github
simplify
64f9110
@elliott-with-the-longest-name-on-github
feat: hoisting
de48a77
@elliott-with-the-longest-name-on-github
fix: $effect.pending sends updates to incorrect boundary
02b7372
@elliott-with-the-longest-name-on-github
changeset
bd6a414
@elliott-with-the-longest-name-on-github
stuff from upstream
f0b01f7
@elliott-with-the-longest-name-on-github
feat: first hydrationgaa
3c73cc7
@elliott-with-the-longest-name-on-github
Merge branch 'elliott/effect-pending-correct-boundary' into adjust-bo…
380f457 
…undary-error-message
@elliott-with-the-longest-name-on-github
remove docs
f98aa72
@elliott-with-the-longest-name-on-github
Merge remote-tracking branch 'origin' into adjust-boundary-error-message
a8fc627
@elliott-with-the-longest-name-on-github
snapshots
5d04b3b
@elliott-with-the-longest-name-on-github
silly fix
a30de03
@elliott-with-the-longest-name-on-github
checkpoint
41e26b5
@elliott-with-the-longest-name-on-github
meh
d4bd8e3
@elliott-with-the-longest-name-on-github
ALKASJDFALSKDFJ the test passes
26d6613
Rich-Harris
Rich-Harris reviewed Sep 15, 2025
View reviewed changes
packages/svelte/src/internal/server/index.js
Comment on lines +127 to +132
/**
* TODO THIS NEEDS TO ACTUALLY BE DONE
* Array of `onDestroy` callbacks that should be called at the end of the server render function
* @type {Function[]}
*/
export let async_on_destroy = [];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have a separate async_on_destroy array? why aren't we continuing to use on_destroy exclusively, and just deferring running the callbacks until render_async is complete?

Given that we're only assigning to async_on_destroy at the start of render_async, surely if you do this...

renderAsync(Component1, ...);
renderAsync(Component2, ...);

...any onDestroy callbacks encountered in a child of Component1 after an await will be associated with Component2, unless Component2 happens to finish first and reset it? To be honest unless we're prepared to instrument every await expression I don't see a way around using AsyncLocalStorage here.

(Idle thought, we may face similar challenges around context)

Rich-Harris
Rich-Harris reviewed Sep 15, 2025
View reviewed changes
Rich-Harris
Rich-Harris reviewed Sep 15, 2025
View reviewed changes
@Rich-Harris Rich-Harris mentioned this pull request Sep 15, 2025
Merged
Rich-Harris
Rich-Harris reviewed Sep 16, 2025
View reviewed changes
Rich-Harris
Rich-Harris reviewed Sep 16, 2025
View reviewed changes
packages/svelte/src/internal/server/context.js
Comment on lines +75 to +76
// TODO this is probably actually broken
async_on_destroy.push(...ondestroy);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving a comment here so we don't lose track of this

Rich-Harris
Rich-Harris reviewed Sep 16, 2025
View reviewed changes
packages/svelte/src/internal/server/payload.js
Comment on lines +104 to +105
// TODO more-proper error
throw new Error('Encountered an asynchronous component while rendering synchronously');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rich-Harris Rich-Harris Rich-Harris left review comments

@dummdidumm dummdidumm dummdidumm left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elliott-with-the-longest-name-on-github @Rich-Harris @dummdidumm