[Messenger] backport #54167: retry AMQPConnectionException on publish#1
Merged
modess merged 1 commit intoApr 9, 2026
Conversation
Ports the upstream Symfony 5.4/6.4 fix for symfony/symfony#48241 into this 4.4 fork. Wraps Connection::publish() in withConnectionExceptionRetry() which catches \AMQPConnectionException, drops cached channel/queues/exchanges via clear(), and retries up to 3 times with no backoff. Fixes intermittent AMQPS publish failures against AWS AmazonMQ caused by AWS NLB's 350s idle TCP timeout silently killing connections — ext-amqp's isConnected() doesn't detect the dead socket so the next publish surfaces as "Library error: a SSL error occurred". Upstream PR: symfony/symfony#54167 Upstream issue: symfony/symfony#48241
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Author
|
@CodeRabbit full review |
✅ Actions performedFull review triggered. |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Transport/AmqpExt/Connection.php (1)
464-472: Consider logging retry attempts for observability.Silent retries can make debugging production issues harder. Adding a log entry when retries occur would help operators understand connection instability without examining metrics or traces.
Example (if a logger is available or can be injected):
// Inside the catch block, before clear(): // $this->logger?->warning('AMQP connection exception, retrying ({retries}/{maxRetries})', [...]); $this->clear();This is optional if the goal is strict parity with upstream.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Transport/AmqpExt/Connection.php` around lines 464 - 472, Add an observability log inside the AMQPConnectionException catch in Connection.php so retry attempts are recorded: inside the catch block that handles \AMQPConnectionException for the $callable() invocation, emit a warning (using $this->logger or an injected logger) that includes current $retries and $maxRetries and the exception message/stack before calling $this->clear(), then preserve the existing increment-and-goto retry behavior; reference the catch around $callable(), the $retries/$maxRetries variables, and $this->clear() when making the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@Transport/AmqpExt/Connection.php`:
- Around line 464-472: Add an observability log inside the
AMQPConnectionException catch in Connection.php so retry attempts are recorded:
inside the catch block that handles \AMQPConnectionException for the $callable()
invocation, emit a warning (using $this->logger or an injected logger) that
includes current $retries and $maxRetries and the exception message/stack before
calling $this->clear(), then preserve the existing increment-and-goto retry
behavior; reference the catch around $callable(), the $retries/$maxRetries
variables, and $this->clear() when making the change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: da2fac32-ab82-4570-ba90-a86f36a6eb3c
📒 Files selected for processing (1)
Transport/AmqpExt/Connection.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backports symfony/symfony#54167 into this 4.4 fork to fix intermittent AMQPS publish failures against AWS AmazonMQ.
Root cause
AWS NLB's 350s idle TCP timeout on TLS listeners silently kills AMQPS connections.
ext-amqp'sisConnected()does not detect the dead socket, so the nextpublish()hits OpenSSL on an RST'd socket and surfaces asLibrary error: a SSL error occurred/stream_socket_enable_crypto()warnings. This is exactly symfony/symfony#48241.Fix
Wraps
Connection::publish()inwithConnectionExceptionRetry():\AMQPConnectionExceptionclear()to drop cached$amqpChannel/$amqpQueues/$amqpExchange/$amqpDelayExchangeclearWhenDisconnected()refactored to delegate to the newclear()helper. Style matches the fork (direct= nullassignment, notunset()).Testing
php -lpassesAmqpExtConnectionRetryTestcovering retry-on-AMQPConnectionException, exhaustion after 3 retries, andclear()semantics (4/4 green)Consumer
sweetspotio/sweetspot-api-platform#4965 will bump its composer pin to this fork HEAD once merged.
Upstream refs
Summary by CodeRabbit