Fix a few simple sendability issues #832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We're about to go on a sendability journey. Let's pick some low hanging fruit to get started. Modifications: - Add a few assume-isolated calls - Stop using static var - Use a dispatch group instead of a work item to wait for work to be done. Result: Fewer warnings
Lukasa
reviewed
Apr 28, 2025
| @@ -223,17 +223,18 @@ public class HTTPClient { | |||
| ) | |||
| } | |||
| let errorStorage: NIOLockedValueBox<Error?> = NIOLockedValueBox(nil) | |||
| let continuation = DispatchWorkItem {} | |||
| let dispatchGroup = DispatchGroup() | |||
| dispatchGroup.enter() | |||
There was a problem hiding this comment.
Nit: this should probably use the condition variable workaround we used in NIO to avoid triggering the main thread checker.
There was a problem hiding this comment.
Ah yeah, good idea
gjcairo
reviewed
Apr 28, 2025
| @@ -26,7 +26,9 @@ extension HTTPConnectionPool { | |||
| self.connection = connection | |||
| } | |||
|
|
|||
| static let none = Action(request: .none, connection: .none) | |||
There was a problem hiding this comment.
Potentially silly question but was this unsafe?
There was a problem hiding this comment.
It's not "unsafe" per-se as neither .none case contains anything. However, Action isn't Sendable (and shouldn't be) so the compiler appropriately produces a warning here.
Lukasa
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We're about to go on a sendability journey. Let's pick some low hanging fruit to get started.
Modifications:
Result:
Fewer warnings