Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Reorder Event and Context. #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2021
Merged

Reorder Event and Context. #224

merged 1 commit into from
Aug 24, 2021

Conversation

fabianfett
Copy link
Member

Fixes #89, for ByteBufferLambdaHandler and EventLoopLambdaHandler protocol.

In the new LambdaHandler protocol, the event already is in front of the context. Let's do the same for ByteBufferLambdaHandler and EventLoopLambdaHandler.

@fabianfett fabianfett added the ⚠️ semver/major Breaks existing public API. label Aug 24, 2021
@fabianfett fabianfett added this to the 1.0.0-alpha.1 milestone Aug 24, 2021
@fabianfett fabianfett requested a review from tomerd August 24, 2021 22:10
@tomerd tomerd merged commit dbd675d into swift-server:main Aug 24, 2021
@fabianfett fabianfett deleted the ff-change-context-event-order branch August 24, 2021 22:32
ktoso
ktoso reviewed Aug 24, 2021
View reviewed changes
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see it, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktoso ktoso ktoso left review comments

@tomerd tomerd tomerd approved these changes

Assignees
No one assigned
Labels
⚠️ semver/major Breaks existing public API.
Projects
None yet
Milestone
1.0.0-alpha.1
Development

Successfully merging this pull request may close these issues.

Reorder context, future-proof for a tracing context world
3 participants
@fabianfett @ktoso @tomerd