[lldb] Remove the Swift-specific diagnosis frame callback #10685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature was originally added to communicate Swift module import failures in per-module SwiftASTContext instances powering "frame variable" to the user. We no longer rely on per-module SwiftASTContexts so it's no longer needed to store these diagnostics long-term to display them to all debuggers using the same lldb::Module. Instead this patch diagnoses them immediately using Debugger::ReportWarning/Error, and since they can only happen when setting up an expression evaluator, they will also be displayed in a timely manner. rdar://150066908
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature was originally added to communicate Swift module import failures in per-module SwiftASTContext instances powering "frame variable" to the user. We no longer rely on per-module SwiftASTContexts so it's no longer needed to store these diagnostics long-term to display them to all debuggers using the same lldb::Module. Instead this patch diagnoses them immediately using Debugger::ReportWarning/Error, and since they can only happen when setting up an expression evaluator, they will also be displayed in a timely manner.
rdar://150066908