Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[5.9] [clang] NFC: A couple of test fixes #7047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2023
Merged

[5.9] [clang] NFC: A couple of test fixes #7047

merged 2 commits into from
Jul 1, 2023

Conversation

hamishknight
Copy link

@hamishknight hamishknight commented Jun 30, 2023 •
edited
Loading

5.9 cherry-pick of #7046

  • Explanation: Fixes a couple of unit tests in the Clang test suite
  • Scope: Only affects tests, though requires tweaking a function defined in Clang
  • Risk: Low, this is NFC
  • Testing: Edited existing tests
  • Reviewer: Ben Barham

@hamishknight hamishknight changed the title [5.9] [unittests] Fix ReparseWorkingDirTest for Windows [5.9] [clang] NFC: A couple of test fixes Jun 30, 2023
@hamishknight
[clang] Fix leak in LoadFromCommandLineWorkingDirectory unit test
ee53319 
Change `ASTUnit::LoadFromCommandLine` to return a `std::unique_ptr`
instead of a +1 pointer, fixing a leak in the unit test
`LoadFromCommandLineWorkingDirectory`.
@hamishknight hamishknight force-pushed the time-and-place-5.9-2 branch from 2d1f084 to ee53319 Compare June 30, 2023 21:24
@hamishknight
Copy link
Author

@swift-ci please test

@bnbarham bnbarham merged commit 2ac8da0 into swiftlang:swift/release/5.9 Jul 1, 2023
@hamishknight hamishknight deleted the time-and-place-5.9-2 branch July 1, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamishknight @bnbarham