Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Move llvm:Error types #69226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Move llvm:Error types #69226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Move llvm:Error types 
Older compilers don't have the copy-elision of newer C++ compilers,
resulting in an error message when returning a non-copyable type. Move
llvm::Error instead of copying it.
  • Loading branch information
@etcwilde
etcwilde committed Oct 17, 2023
commit 6608235b0d93ac36867658aa8a4e441a0be691dc
4 changes: 2 additions & 2 deletions lib/Frontend/CachingUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ Expected<bool> cas::CachedResultLoader::replay(CallbackTy Callback) {
[&](swift::cas::CompileJobCacheResult::Output Output) -> Error {
return Callback(Output.Kind, Output.Object);
}))
return Err;
return std::move(Err);

return true;
}
Expand Down Expand Up @@ -120,7 +120,7 @@ Expected<bool> cas::CachedResultLoader::replay(CallbackTy Callback) {
"Unexpected output kind in clang cached result");
return Callback(OutputKind, Output.Object);
}))
return Err;
return std::move(Err);

return true;
}
Expand Down