Fix ownership issues with sequences of partial_apply's in AutoDiff closure specialization pass #80662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AutoDiff closure specialization pass: each partial_apply consumes its arguments, therefore we should never release intermediate ones in the sequence of closures. Fixes #78847
|
I also added end-to-end swift test to test the pass, apparently there are no tests for this. |
|
@swift-ci please test |
|
The explanation of wrong behavior is in #78847 (comment) |
|
Reenabling it back also gives huge performance boost. We are having (on benchmark from #80665) Before: After: |
|
@swift-ci please test |
|
Tagging @JaapWijnen |
|
Nice! Also the performance boost. Is this boost related to the loss in performance we saw in January @asl ? Or separate and thus an improvement on top of the performance we had in early January? |
|
@JaapWijnen Correct. This brings the performance back to January figures @eeckstein Here is what happened:
|
|
Looks good from what I can tell. Thanks for fixing! |
jkshtj
approved these changes
Apr 9, 2025
acb54c2 to
a2c214c
Compare
|
@swift-ci please test |
|
@swift-ci please smoke test |
clackary
pushed a commit
to clackary/swift
that referenced
this pull request
May 1, 2025
Fix ownership issues with sequences of partial_apply's in AutoDiff closure specialization pass (swiftlang#80662) Each partial_apply consumes its arguments, therefore we should never release intermediate ones in the sequence of closures. Fixes swiftlang#78847 (cherry picked from commit 87ca0f8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each partial_apply consumes its arguments, therefore we should never release intermediate ones in the sequence of closures.
Fixes #78847