Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Merge exported modules with the same public name in generated interface #80958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

Merge exported modules with the same public name in generated interface #80958

merged 1 commit into from
May 5, 2025
+2,854 −2,994

Conversation

bnbarham
Copy link
Contributor

@bnbarham bnbarham commented Apr 21, 2025 •
edited
Loading

If a module has the same public-module-name as the module being
generated and its import is exported, merge it into the same generated
interface.

Fix various always-imported modules from being printed while here and
update all the tests that checked for them.

Resolves rdar://137887712.

@bnbarham bnbarham requested a review from xymus April 21, 2025 18:41
@bnbarham
Copy link
Contributor Author

@swift-ci please test

xymus
xymus approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor

@xymus xymus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good!

@bnbarham bnbarham force-pushed the merge-modules branch 2 times, most recently from 60da292 to c718a50 Compare May 1, 2025 03:44
@bnbarham
Copy link
Contributor Author

bnbarham commented May 1, 2025

@swift-ci please test

@bnbarham
Copy link
Contributor Author

bnbarham commented May 1, 2025

@swift-ci please test

@nkcsgexi
Copy link
Contributor

nkcsgexi commented May 1, 2025

Thank you for fixing this, Ben!

@bnbarham
Copy link
Contributor Author

bnbarham commented May 1, 2025

@swift-ci please test

@bnbarham
Copy link
Contributor Author

bnbarham commented May 2, 2025

@swift-ci please test

@bnbarham
Merge exported modules with the same public name in generated interface
ddddc66 
If a module has the same `public-module-name` as the module being
generated and its import is exported, merge it into the same generated
interface.

Fix various always-imported modules from being printed while here and
update all the tests that checked for them.

Resolves rdar://137887712.
@bnbarham
Copy link
Contributor Author

bnbarham commented May 2, 2025

@swift-ci please test

rintaro
rintaro approved these changes May 2, 2025
View reviewed changes
Copy link
Member

@rintaro rintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bnbarham bnbarham mentioned this pull request May 2, 2025
Open
@bnbarham bnbarham merged commit 0bf1c1f into swiftlang:main May 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rintaro rintaro rintaro approved these changes

@xymus xymus xymus approved these changes

@ahoppen ahoppen Awaiting requested review from ahoppen ahoppen is a code owner

@hamishknight hamishknight Awaiting requested review from hamishknight hamishknight is a code owner

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

@tshortli tshortli Awaiting requested review from tshortli tshortli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bnbarham @nkcsgexi @rintaro @xymus