Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add typing to update_checkout.py #81160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025
Merged

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Apr 29, 2025

As Python 3.5 added support for type hints and we require Python 3.6 or later, let's try to add a type hint to a single function so that development experience is slightly improved and we can test this feature in our code before applying it more widely. Editors with support for Python LSP servers can pick it and stop flagging this function or its invocations as type errors.

As Python 3.5 added support for type hints and we require Python 3.6 or later, let's try to add a type hint for a function so that development experience is improved. Editors with support for Python LSP servers can pick it and stop flagging this function or its invocations as type errors.
@MaxDesiatov
Copy link
Contributor Author

@swift-ci smoke test

@MaxDesiatov MaxDesiatov added python Flag: Python source code update-checkout Area → utils: the `update-checkout` script labels Apr 29, 2025
Copy link
Contributor

@edymtt edymtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this -- would it be ok to reach out to you in case this causes unforeseen issues?

@MaxDesiatov
Copy link
Contributor Author

I am fine with this -- would it be ok to reach out to you in case this causes unforeseen issues?

Yes, for sure. Thanks!

@MaxDesiatov MaxDesiatov merged commit fa8f747 into main May 9, 2025
3 checks passed
@MaxDesiatov MaxDesiatov deleted the maxd/update-checkout-typing branch May 9, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Flag: Python source code update-checkout Area → utils: the `update-checkout` script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants