-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[stdlib] make _overrideLifetime()
functions public
#81224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These are discussed in the lifetime annotations pitch: swiftlang/swift-evolution#2750 Addresses rdar://150400414
@swift-ci please smoke test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is super helpful.
@glessard you can remove these TODOs now:
They were originally to discourage people from using |
These TODOs aren’t particularly actionable. What we really want is a way to define `_overrideLifetime()` in a not-unsafe way, and that will probably be a `Builtin` operation.
@swift-ci please smoke test |
These functions are discussed in the lifetime annotations pitch: swiftlang/swift-evolution#2750
They are necessary to implement functions returning non-escapable values, such as
Data.bytes
.Addresses rdar://150400414