[6.2][Macros] Don't include attr range when checking macro definition #81357
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For macro definition checking, we use the range of the `macro` declaration and re-parse it with `SwiftParser`. Previously it uses the range including the attributes, but that can result invalid code because the attribute can be in a `#if ... #endif` region. Since we don't use attributes for checking the definition, just use the range without the attributes instead. rdar://150805795 (cherry picked from commit 8519e71)
|
@swift-ci Please test |
bnbarham
approved these changes
May 7, 2025
There was a problem hiding this comment.
CC @DougGregor in case you know of a reason we were including attributes here. But as far as we can tell they end up being unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #81346 into
release/6.2macrodeclaration and re-parse it withSwiftParser. Previously it uses the range including the attributes, but that can result invalid code because the attribute can be in a#if ... #endifregion. Since we don't use attributes for checking the definition, just use the range without the attributes instead.