[6.2] Cherry-pick "Frontend: Obsolete -fixit-all and -emit-fixits-path"
#81358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…path`" With `ARCMigrate` and `arcmt-test` removed from clang in llvm/llvm-project#119269 and the new code migration experience under way (see swiftlang/swift-evolution#2673), these options are no longer relevant nor known to be in use. They were introduced long ago to support fix-it application in Xcode. For now, turn them into a no-op and emit a obsoletion warning. (cherry picked from commit 46c394788a84d5932289c71274dd32ea2d61d9dc)
…sts into subdirectory" (cherry picked from commit b0b0cff)
…t files after..." ...swiftlang#81280. (cherry picked from commit 3cf3d62)
…n..." ...swiftlang#81280. The deleted test was `test/FixCode/fixits-if-else.swift`. Resurrect it in a better place and switch it to the diagnostic verifier, as it was intended to along with other moved tests in that PR. (cherry picked from commit 8928b53)
|
Do we need a swift-driver change for this as well? |
bnbarham
approved these changes
May 7, 2025
|
@swift-ci please test |
From what I gather, swift-driver just forwards these options to the frontend without any special treatment, so probably not? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: With
ARCMigrateandarcmt-testremoved from clang in [Clang] Remove ARCMigrate llvm/llvm-project#119269 and the new code migration experience under way (see Migration tooling for Swift features swift-evolution#2673), these options are no longer relevant nor known to be in use. They were introduced long ago to support fix-it application in Xcode.For now, turn them into a no-op and emit a obsoletion warning.
Scope: Frontend options.
Issues: rdar://150553068.
Original PRs:
-fixit-alland-emit-fixits-path#81280Risk: Low. These options were not intended for widespread use, and we are not aware of any external dependents.
Testing: Rehoused and refactored all tests that depended on these options specifically to verify fix-its. Also added a test for the new obsoletion warning.
Reviewers: @xedin