Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove disabled asserts in LifetimeDependence #81362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

meg-gupta
Copy link
Contributor

@meg-gupta meg-gupta commented May 7, 2025

Asserts in LifetimeDependence was previously disabled during the bringup of ~Escapable Optional because they were firing on AsyncNinja. I am enabling it back because I cannot reproduce it. Also turning it into ASSERT which will fire in no-asserts build in case this turns out to be an intermittent failure.

@meg-gupta
Copy link
Contributor Author

@swift-ci test source compatibility

@meg-gupta
Copy link
Contributor Author

@swift-ci build toolchain

@meg-gupta
Copy link
Contributor Author

@swift-ci test

@meg-gupta meg-gupta marked this pull request as ready for review May 8, 2025 17:30
@meg-gupta meg-gupta requested review from atrick and lorentey May 8, 2025 18:05
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Thanks!

@meg-gupta meg-gupta merged commit 1cdfd01 into swiftlang:main May 8, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants