[FreeBSD]: Optional observation pthread primitives #81366
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pthread APIs on FreeBSD do not include nullability APIs so the pthread mutex APIs are imported as pointers to optional values. Other platforms include nullability APIs and import the pthread APIs as pointers to the mutex. Splitting the locking primitive type based on the OS. Fixes: rdar://150880976
|
@swift-ci please test |
|
Longer-term, should we be API-noting these on *BSD? |
stephentyrone
approved these changes
May 8, 2025
3405691582
reviewed
May 8, 2025
| @@ -34,7 +34,11 @@ internal struct Lock { | |||
| #if canImport(Darwin) | |||
| typealias Primitive = os_unfair_lock | |||
| #elseif canImport(Glibc) || canImport(Musl) || canImport(Bionic) | |||
| #if os(FreeBSD) | |||
There was a problem hiding this comment.
This is also the case for os(OpenBSD). Can you add this as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pthread APIs on FreeBSD do not include nullability APIs so the pthread mutex APIs are imported as pointers to optional values. Other platforms include nullability APIs and import the pthread APIs as pointers to the mutex. Splitting the locking primitive type based on the OS.
Fixes: rdar://150880976