Thanks to visit codestin.com
Credit goes to github.com

Skip to content

EmbeddedSwiftDiagnostics: fix and improve some embedded diagnostic errors #81373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 9, 2025
Merged

EmbeddedSwiftDiagnostics: fix and improve some embedded diagnostic errors #81373

merged 5 commits into from
May 9, 2025
+119 −38

Conversation

eeckstein
Copy link
Contributor

@eeckstein eeckstein commented May 8, 2025 •
edited
Loading

  • fix a wrong "cannot use co-routines (like accessors) in -no-allocations mode" error
  • force inlining of transparent co-routines. This might be necessary if -enable-testing is turned on, because in this mode function linkages are different than in a regular build.
  • check apply diagnostics also for begin_apply and partial_apply
  • improve error message for non-specialized generic function calls: tell the user if the specialization isn't done because of a dynamic Self type.

rdar://150890424
rdar://150865684

@eeckstein eeckstein requested a review from kubamracek May 8, 2025 06:40
@eeckstein
Copy link
Contributor Author

@swift-ci smoke test

@eeckstein eeckstein force-pushed the fix-embedded-error branch from 015ce98 to 38bdd21 Compare May 8, 2025 08:26
@eeckstein eeckstein changed the title EmbeddedSwiftDiagnostics: fix a wrong "cannot use co-routines (like accessors) in -no-allocations mode" error EmbeddedSwiftDiagnostics: fix and improve some embedded diagnostic errors May 8, 2025
@eeckstein
Copy link
Contributor Author

@swift-ci smoke test

MaxDesiatov
MaxDesiatov approved these changes May 8, 2025
View reviewed changes
Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MaxDesiatov
Copy link
Contributor

@swift-ci build toolchain

@MaxDesiatov MaxDesiatov self-requested a review May 8, 2025 11:24
eeckstein added 5 commits May 8, 2025 19:21
@eeckstein
MandatoryPerformanceOptimizations: force inlining of transparent co-r…
9348f5e 
…outines

This might be necessary if `-enable-testing` is turned on, because in this mode function linkages are different than in a regular build.
@eeckstein
EmbeddedSwiftDiagnostics: fix a wrong "cannot use co-routines (like a…
d9c7a68 
…ccessors) in -no-allocations mode" error

rdar://150890424
@eeckstein
EmbeddedSwiftDiagnostics: check apply diagnostics also for `begin_app…
f52f491 
…ly` and `partial_apply`
@eeckstein
Swift AST: add Type.hasDynamicSelf
aacb4d4
@eeckstein
EmbeddedSwiftDiagnostics: improve error message for non-specialized g…
be32287 
…eneric function calls

Tell the user if the specialization isn't done because of a dynamic Self type.

rdar://150865684
@eeckstein eeckstein force-pushed the fix-embedded-error branch from 38bdd21 to be32287 Compare May 8, 2025 17:22
@eeckstein
Copy link
Contributor Author

@swift-ci smoke test

@eeckstein eeckstein merged commit 3b6805a into swiftlang:main May 9, 2025
3 checks passed
@eeckstein eeckstein deleted the fix-embedded-error branch May 9, 2025 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubamracek kubamracek kubamracek approved these changes

@MaxDesiatov MaxDesiatov Awaiting requested review from MaxDesiatov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eeckstein @MaxDesiatov @kubamracek