[6.2] Fix argument index calculations for isolated default arguments #81377
+168
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainPR: #81370Explanation: The calculation of argument indices for isolated default arguments has a bug which is, fortunately, hidden by a second bug unless isolated default arguments are interleaved with other arguments, such as if an intermediate argument is provided explicitly by the call or meets the narrow conditions for being recognized as non-isolated.
Scope: affects the code path for all calls with isolated default arguments
Risk: Low: the survival of this bug until now suggests that existing code does not heavily exercise it
Testing: regression testing, new patch
Issue: rdar://150060837
Reviewer: Doug Gregor