[6.2][IRGen] Emit llvm fneg operation for Builtin.fneg_* #81381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
drexin
commented
May 8, 2025
•
- Explanation: The original handling was a workaround before LLVM added the fneg operation. Now that it has it, we should use it.
- Scope: IRGen for FNeg builtin
- Issues: rdar://150722907
- Original PRs: [IRGen] Emit llvm fneg operation for Builtin.fneg_* #81339
- Risk: Low. Replaces an approximation of an instruction with the instruction itself
- Testing: Adjusted existing tests to use the new instruction
- Reviewers: @rjmccall @stephentyrone
rdar://150722907 The original handling was a workaround before LLVM added the fneg operation. Now that it has it, we should use it.
stephentyrone
approved these changes
May 8, 2025
|
@swift-ci test |
|
@swift-ci test macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.