Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Reenable build of compiler-rt with LLVM_ENABLE_RUNTIMES in Linux bots... #81386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

edymtt
Copy link
Contributor

@edymtt edymtt commented May 8, 2025

...we disabled in #81354

This requires a couple of supporting changes

  • under Linux, do not cross compile by default -- that will ensure that
    the compiler-rt build will use the just built compiler and not the
    system one (which may not be new enough for this purpose);
  • provide sanitizer flags depending on the linker the just built compiler
    will use -- this detection is brittle, so ensure the user can override
    those if needed.

Addresses rdar://150849329

edymtt and others added 4 commits May 7, 2025 07:04
The existing swift-cmake-options flag overwrites all flags computed by
build-script. Sometimes it is useful to be able to append additional
CMake flags without overwriting the existing flags.
This patch adds `--extra-swift-cmake-options` that adds the specified
flags to the Swift CMake configuration instead of overwriting them.

This also adds a similar `--extra-llvm-cmake-options`, which adds the
new flags to the end, allowing one to replace and overwrite CMake flags
that build-script computed.
Due to the parameter passing mechanisms in build-script-impl, while this
behavior would be useful for Swift, it is not immediately apparent how
one would best implement this at this time.
...we disabled in swiftlang#81354

This requires a couple of supporting changes

* under Linux, do not cross compile by default -- that will ensure that
  the compiler-rt build will use the just built compiler and not the
system one (which may not be new enough for this purpose);
* provide sanitizer flags depending on the linker the just built compiler
 will use -- this detection is brittle, so ensure the user can override
those if needed.

Addresses rdar://150849329
@edymtt
Copy link
Contributor Author

edymtt commented May 8, 2025

@swift-ci please build toolchain

@edymtt
Copy link
Contributor Author

edymtt commented May 8, 2025

@swift-ci please build toolchain Ubuntu 24.04 aarch64

@edymtt
Copy link
Contributor Author

edymtt commented May 8, 2025

@swift-ci please build toolchain Ubuntu 22.04 aarch64

@edymtt
Copy link
Contributor Author

edymtt commented May 8, 2025

@swift-ci please build toolchain Amazon Linux 2 aarch64

@edymtt
Copy link
Contributor Author

edymtt commented May 8, 2025

@swift-ci please build toolchain Amazon Linux 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants