[6.4] [cxx-interop] Guard Span-referencing declarations in Cxx module interface behind version check#89195
Open
patrykstefanski wants to merge 1 commit into
Conversation
…face behind version check When a newer toolchain (Swift >=6.2) is used with an older SDK whose stdlib predates Swift 6.2, the Cxx module interface references `Swift.Span` and `Swift.MutableSpan` which don't exist in the older stdlib, causing build failures. Guard individual declarations in the Cxx overlay that reference `Span`/`MutableSpan` behind `#if canImport(Swift, _version: 6.2)`. The guard wraps (rather than replaces) existing feature-based guards like `$LifetimeDependence`, so both compiler capability and stdlib availability are checked. rdar://176312542 (cherry picked from commit 9e057e5)
Contributor
Author
|
@swift-ci please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a newer toolchain (Swift >=6.2) is used with an older SDK whose stdlib predates Swift 6.2, the Cxx module interface references
Swift.SpanandSwift.MutableSpanwhich don't exist in the older stdlib, causing build failures.Guard individual declarations in the Cxx overlay that reference
Span/MutableSpanbehind#if canImport(Swift, _version: 6.2). The guard wraps (rather than replaces) existing feature-based guards like$LifetimeDependence, so both compiler capability and stdlib availability are checked.rdar://176312542
(cherry picked from commit 9e057e5)
TODO: Fill template